[ic] Port {Load,Store}IC_Normal to TF

[ic] Port {Load,Store}IC_Normal to TF

BUG=v8:5269
Review-Url: https://codereview.chromium.org/2622003004
Cr-Commit-Position: refs/heads/master@{#42261}
Committed: https://chromium.googlesource.com/v8/v8/+/d23e7d2f813fecfa7aff73621b3a26d11805dfd4

[Jakob Kummerow, 2017-01-11 16:31:21]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2017-01-11 16:31:21]

PTAL.

[Igor Sheludko, 2017-01-11 16:50:34]

lgtm with a nit:

https://codereview.chromium.org/2622003004/diff/1/src/builtins/builtins-handl...
File src/builtins/builtins-handler.cc (right):

https://codereview.chromium.org/2622003004/diff/1/src/builtins/builtins-handl...
src/builtins/builtins-handler.cc:194: const int kTypeAndReadOnlyMask =
PropertyDetails::TypeField::kMask |
This should be KindField::kMask since you don't care about location part.

[Jakob Kummerow, 2017-01-12 10:24:11]

Thanks, landing.

https://codereview.chromium.org/2622003004/diff/1/src/builtins/builtins-handl...
File src/builtins/builtins-handler.cc (right):

https://codereview.chromium.org/2622003004/diff/1/src/builtins/builtins-handl...
src/builtins/builtins-handler.cc:194: const int kTypeAndReadOnlyMask =
PropertyDetails::TypeField::kMask |
On 2017/01/11 16:50:34, Igor Sheludko wrote:
> This should be KindField::kMask since you don't care about location part.

Done.

[Jakob Kummerow, 2017-01-12 10:24:22]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-01-12 10:24:23]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2622003004/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2017-01-12 10:24:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 10:53:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484216662639700,
"parent_rev": "3d9e2ea32d2cd09e5087cc507ee750fc2c18fbef", "commit_rev":
"d23e7d2f813fecfa7aff73621b3a26d11805dfd4"}

[commit-bot: I haz the power, 2017-01-12 10:53:14]

Description was changed from

==========
[ic] Port {Load,Store}IC_Normal to TF

BUG=v8:5269
==========

to

==========
[ic] Port {Load,Store}IC_Normal to TF

BUG=v8:5269

Review-Url: https://codereview.chromium.org/2622003004
Cr-Commit-Position: refs/heads/master@{#42261}
Committed:
https://chromium.googlesource.com/v8/v8/+/d23e7d2f813fecfa7aff73621b3a26d1180...
==========

[commit-bot: I haz the power, 2017-01-12 10:53:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d23e7d2f813fecfa7aff73621b3a26d1180...