Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 26220004: SkRectShaderImageFilter: add a new factory method which takes a CropRect. (Closed)

Created:
7 years, 2 months ago by Stephen White
Modified:
7 years, 2 months ago
Reviewers:
reed, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SkRectShaderImageFilter: add a new factory method which takes a CropRect. This will become the preferred API, and the old Create method will be deprecated. R=reed@google.com, reed BUG= Committed: https://code.google.com/p/skia/source/detail?r=11773

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve docs #

Patch Set 3 : More docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M include/effects/SkRectShaderImageFilter.h View 1 2 1 chunk +11 lines, -5 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
Take two: PTAL. Thanks!
7 years, 2 months ago (2013-10-12 17:19:50 UTC) #1
reed1
https://codereview.chromium.org/26220004/diff/1/include/effects/SkRectShaderImageFilter.h File include/effects/SkRectShaderImageFilter.h (right): https://codereview.chromium.org/26220004/diff/1/include/effects/SkRectShaderImageFilter.h#newcode21 include/effects/SkRectShaderImageFilter.h:21: * The region parameter is used to specify on ...
7 years, 2 months ago (2013-10-14 12:45:57 UTC) #2
Stephen White
On 2013/10/14 12:45:57, reed1 wrote: > https://codereview.chromium.org/26220004/diff/1/include/effects/SkRectShaderImageFilter.h > File include/effects/SkRectShaderImageFilter.h (right): > > https://codereview.chromium.org/26220004/diff/1/include/effects/SkRectShaderImageFilter.h#newcode21 > ...
7 years, 2 months ago (2013-10-15 14:59:36 UTC) #3
Stephen White
New patch up; PTAL. Thanks!
7 years, 2 months ago (2013-10-15 15:01:09 UTC) #4
reed1
lgtm
7 years, 2 months ago (2013-10-15 15:05:31 UTC) #5
Stephen White
7 years, 2 months ago (2013-10-15 15:25:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r11773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698