Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Issue 2621993006: Drop the -webkit prefix from user-select CSS rule in ui/. (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, posciak+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, dglazkov
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop the -webkit prefix from user-select CSS rule in ui/. It's been implemented as just "user-select" since Chrome 54. This was accomplished with: for type in none text auto; do git gs "\-webkit-user-select: $type;" -l | \ xargs perl -p -i -e "s/-webkit-user-select: $type;/user-select: $type;/g" done And a bunch of manual alpha sorting of rules :(. R=fukino@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2621993006 Cr-Commit-Position: refs/heads/master@{#443151} Committed: https://chromium.googlesource.com/chromium/src/+/602d5018eae1d34922f1aae754d007acb069f06f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M ui/file_manager/audio_player/css/audio_player.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/combobutton.css View 2 chunks +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/common.css View 4 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 4 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/list.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/table.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/tree.css View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/video_player/css/video_player.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/chrome_shared.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/dialogs.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/expandable_bubble.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/list.css View 2 chunks +1 line, -1 line 0 comments Download
M ui/webui/resources/css/overlay.css View 2 chunks +1 line, -1 line 0 comments Download
M ui/webui/resources/css/table.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/tree.css View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/css/widgets.css View 4 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Dan Beam
3 years, 11 months ago (2017-01-12 00:30:46 UTC) #8
fukino
lgtm
3 years, 11 months ago (2017-01-12 03:57:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621993006/1
3 years, 11 months ago (2017-01-12 04:09:18 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 04:14:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/602d5018eae1d34922f1aae754d0...

Powered by Google App Engine
This is Rietveld 408576698