Fix flaky Android Search Geolocation Disclosure tests.

Fix flaky Android Search Geolocation Disclosure tests.

These tests are flaky because there is a delay between infobars being
removed in the native InfobarManager, and this flowing through the the
Java side of things. This change introduces a polling loop whenever
an infobar is removed to account for this.

BUG=678210
Review-Url: https://codereview.chromium.org/2621983003
Cr-Commit-Position: refs/heads/master@{#443500}
Committed: https://chromium.googlesource.com/chromium/src/+/b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3

[benwells, 2017-01-11 06:04:50]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:05:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:35:28]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-01-11 06:36:22]

benwells@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[benwells, 2017-01-11 06:36:22]

benwells@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2017-01-11 18:15:42]

lgtm

https://codereview.chromium.org/2621983003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java
(right):

https://codereview.chromium.org/2621983003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java:54:
private void waitUntilNoInfoBarsExist() {
Pull this and the other two copies into InfoBarUtil.java?

[benwells, 2017-01-12 23:30:34]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:31:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:17:56]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-01-13 04:26:27]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 04:27:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:58:49]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-01-13 05:01:26]

benwells@chromium.org changed reviewers:
+ dominickn@chromium.org

[benwells, 2017-01-13 05:01:26]

Hey Dom, this has changed a lot doing Dan's request, so having some kind of
review would be nice. Plus it is mostly in your test!

https://codereview.chromium.org/2621983003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java
(right):

https://codereview.chromium.org/2621983003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java:54:
private void waitUntilNoInfoBarsExist() {
On 2017/01/11 18:15:42, dfalcantara (load balance plz) wrote:
> Pull this and the other two copies into InfoBarUtil.java?

Done.

https://codereview.chromium.org/2621983003/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
(left):

https://codereview.chromium.org/2621983003/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java:189:
CriteriaHelper.pollInstrumentationThread(
Note this is a different thread, and the test failed when I ran it locally as
is. After the change it passed locally.

[benwells, 2017-01-13 05:01:28]

Hey Dom, this has changed a lot doing Dan's request, so having some kind of
review would be nice. Plus it is mostly in your test!

[benwells, 2017-01-13 05:01:29]

Hey Dom, this has changed a lot doing Dan's request, so having some kind of
review would be nice. Plus it is mostly in your test!

[dominickn, 2017-01-13 05:09:06]

lgtm

[benwells, 2017-01-13 05:31:41]

The CQ bit was checked by benwells@chromium.org

[benwells, 2017-01-13 05:31:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2621983003/#ps20001
(title: "Make function common")

[commit-bot: I haz the power, 2017-01-13 05:32:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 05:39:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484285501487570,
"parent_rev": "2c22f5c684f13a4b7b9eeb3ff7007e80e5b1e8b0", "commit_rev":
"b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3"}

[commit-bot: I haz the power, 2017-01-13 05:39:57]

Description was changed from

==========
Fix flaky Android Search Geolocation Disclosure tests.

These tests are flaky because there is a delay between infobars being
removed in the native InfobarManager, and this flowing through the the
Java side of things. This change introduces a polling loop whenever
an infobar is removed to account for this.

BUG=678210
==========

to

==========
Fix flaky Android Search Geolocation Disclosure tests.

These tests are flaky because there is a delay between infobars being
removed in the native InfobarManager, and this flowing through the the
Java side of things. This change introduces a polling loop whenever
an infobar is removed to account for this.

BUG=678210

Review-Url: https://codereview.chromium.org/2621983003
Cr-Commit-Position: refs/heads/master@{#443500}
Committed:
https://chromium.googlesource.com/chromium/src/+/b21f1b10efb4895b91ef5ba1e445...
==========

[commit-bot: I haz the power, 2017-01-13 05:39:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b21f1b10efb4895b91ef5ba1e445...