Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: BUILD.gn

Issue 2621983002: Pull define for version out into v8-version-string.h and separate build target (Closed)
Patch Set: forgotten removal Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8-version-string.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 0daea44e822dc5c6b2469e7acabf14192e05b0aa..58bdb6b6531c57afdfcd02c606e5c8e9584a604e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -851,6 +851,17 @@ if (v8_use_external_startup_data) {
}
}
+# This is split out to be a non-code containing target that the Chromium browser
+# DLL can depend upon to get only a version string.
+v8_source_set("v8_version") {
+ configs = [ ":internal_config" ]
+
+ sources = [
+ "include/v8-version-string.h",
+ "include/v8-version.h",
+ ]
+}
+
v8_source_set("v8_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
@@ -864,7 +875,6 @@ v8_source_set("v8_base") {
"include/v8-profiler.h",
"include/v8-testing.h",
"include/v8-util.h",
- "include/v8-version.h",
"include/v8.h",
"include/v8config.h",
"src/accessors.cc",
@@ -2189,6 +2199,7 @@ v8_source_set("v8_base") {
deps = [
":v8_libbase",
":v8_libsampler",
+ ":v8_version",
]
sources += [ v8_generated_peephole_source ]
« no previous file with comments | « no previous file | include/v8-version-string.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698