Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: BUILD.gn

Issue 2621983002: Pull define for version out into v8-version-string.h and separate build target (Closed)
Patch Set: forgotten removal Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/v8-version-string.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/dcheck_always_on.gni") 7 import("//build/config/dcheck_always_on.gni")
8 import("//build/config/mips.gni") 8 import("//build/config/mips.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 10
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 844
845 sources = [ 845 sources = [
846 "src/snapshot/natives-external.cc", 846 "src/snapshot/natives-external.cc",
847 "src/snapshot/snapshot-external.cc", 847 "src/snapshot/snapshot-external.cc",
848 ] 848 ]
849 849
850 configs = [ ":internal_config" ] 850 configs = [ ":internal_config" ]
851 } 851 }
852 } 852 }
853 853
854 # This is split out to be a non-code containing target that the Chromium browser
855 # DLL can depend upon to get only a version string.
856 v8_source_set("v8_version") {
857 configs = [ ":internal_config" ]
858
859 sources = [
860 "include/v8-version-string.h",
861 "include/v8-version.h",
862 ]
863 }
864
854 v8_source_set("v8_base") { 865 v8_source_set("v8_base") {
855 visibility = [ ":*" ] # Only targets in this file can depend on this. 866 visibility = [ ":*" ] # Only targets in this file can depend on this.
856 867
857 sources = [ 868 sources = [
858 "//base/trace_event/common/trace_event_common.h", 869 "//base/trace_event/common/trace_event_common.h",
859 870
860 ### gcmole(all) ### 871 ### gcmole(all) ###
861 "include/v8-debug.h", 872 "include/v8-debug.h",
862 "include/v8-experimental.h", 873 "include/v8-experimental.h",
863 "include/v8-platform.h", 874 "include/v8-platform.h",
864 "include/v8-profiler.h", 875 "include/v8-profiler.h",
865 "include/v8-testing.h", 876 "include/v8-testing.h",
866 "include/v8-util.h", 877 "include/v8-util.h",
867 "include/v8-version.h",
868 "include/v8.h", 878 "include/v8.h",
869 "include/v8config.h", 879 "include/v8config.h",
870 "src/accessors.cc", 880 "src/accessors.cc",
871 "src/accessors.h", 881 "src/accessors.h",
872 "src/address-map.cc", 882 "src/address-map.cc",
873 "src/address-map.h", 883 "src/address-map.h",
874 "src/allocation-site-scopes.cc", 884 "src/allocation-site-scopes.cc",
875 "src/allocation-site-scopes.h", 885 "src/allocation-site-scopes.h",
876 "src/allocation.cc", 886 "src/allocation.cc",
877 "src/allocation.h", 887 "src/allocation.h",
(...skipping 1304 matching lines...) Expand 10 before | Expand all | Expand 10 after
2182 "src/x87/simulator-x87.h", 2192 "src/x87/simulator-x87.h",
2183 ] 2193 ]
2184 } 2194 }
2185 2195
2186 configs = [ ":internal_config" ] 2196 configs = [ ":internal_config" ]
2187 2197
2188 defines = [] 2198 defines = []
2189 deps = [ 2199 deps = [
2190 ":v8_libbase", 2200 ":v8_libbase",
2191 ":v8_libsampler", 2201 ":v8_libsampler",
2202 ":v8_version",
2192 ] 2203 ]
2193 2204
2194 sources += [ v8_generated_peephole_source ] 2205 sources += [ v8_generated_peephole_source ]
2195 deps += [ ":run_mkpeephole" ] 2206 deps += [ ":run_mkpeephole" ]
2196 2207
2197 if (is_win) { 2208 if (is_win) {
2198 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 2209 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
2199 cflags = [ "/wd4267" ] 2210 cflags = [ "/wd4267" ]
2200 } 2211 }
2201 2212
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
3019 ] 3030 ]
3020 3031
3021 configs = [ 3032 configs = [
3022 ":external_config", 3033 ":external_config",
3023 ":internal_config_base", 3034 ":internal_config_base",
3024 ] 3035 ]
3025 } 3036 }
3026 3037
3027 v8_fuzzer("wasm_data_section_fuzzer") { 3038 v8_fuzzer("wasm_data_section_fuzzer") {
3028 } 3039 }
OLDNEW
« no previous file with comments | « no previous file | include/v8-version-string.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698