Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2621933002: Move eventlog_provider.dll uninstall code to its proper location. (Closed)

Created:
3 years, 11 months ago by pastarmovj
Modified:
3 years, 11 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move eventlog_provider.dll uninstall code to its proper location. It was incorrectly put in a conditional statement that just happened to be always true in the right situation but is not guaranteed to always be this way. BUG=679707 Review-Url: https://codereview.chromium.org/2621933002 Cr-Commit-Position: refs/heads/master@{#442562} Committed: https://chromium.googlesource.com/chromium/src/+/aa4e14837187e3c65d9175961d6e8ce3ca013f3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/installer/setup/uninstall.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pastarmovj
Hi Greg, here is the fix you proposed yesterday. Thanks! Julian
3 years, 11 months ago (2017-01-10 12:11:10 UTC) #4
grt (UTC plus 2)
lgtm. thanks!
3 years, 11 months ago (2017-01-10 12:33:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621933002/1
3 years, 11 months ago (2017-01-10 12:47:23 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 12:51:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa4e14837187e3c65d9175961d6e...

Powered by Google App Engine
This is Rietveld 408576698