Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2621923004: [Sync] Fail softly in SMTP if an error occurs during startup. (Closed)

Created:
3 years, 11 months ago by maxbogue
Modified:
3 years, 11 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fail softly in SMTP if an error occurs during startup. This is a quick fix to stop crashes; I'll do a more robust change in a followup. BUG=679657, 673883 Review-Url: https://codereview.chromium.org/2621923004 Cr-Commit-Position: refs/heads/master@{#442707} Committed: https://chromium.googlesource.com/chromium/src/+/892aca45f80c04a7139ab07c7b1c9b9dd8349eec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M components/sync/model_impl/shared_model_type_processor.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M components/sync/model_impl/shared_model_type_processor_unittest.cc View 2 chunks +16 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
maxbogue
Sky, PTAL!
3 years, 11 months ago (2017-01-10 20:04:45 UTC) #5
skym
lgtm
3 years, 11 months ago (2017-01-10 22:03:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621923004/1
3 years, 11 months ago (2017-01-10 22:04:37 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 22:14:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/892aca45f80c04a7139ab07c7b1c...

Powered by Google App Engine
This is Rietveld 408576698