Remove AudioSourceNode class

Remove AudioSourceNode class

The MediaElementAudioSourceNode and MediaStreamAudioSourceNode were
implemented as deriving from an AudioSourceNode.  This is not part of
the spec; these nodes are derived from AudioNode.  This was only
visible in the prototype chain for these classes.  The AudioSourceNode
is otherwise invisible to the user; it is not constructible and has no
properties.

Thus, remove the AudioSourceNode class.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/D-QJm9GCisc/gSCZwIrfFgAJ

BUG=663818
TEST=none

Review-Url: https://codereview.chromium.org/2621923003
Cr-Commit-Position: refs/heads/master@{#445433}
Committed: https://chromium.googlesource.com/chromium/src/+/717012126c57dfe596b6562f9ad17f2a7e537a5b

[Raymond Toy, 2017-01-10 18:22:15]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[Raymond Toy, 2017-01-10 18:22:25]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-10 18:22:26]

PTAL

[commit-bot: I haz the power, 2017-01-10 18:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hongchan, 2017-01-10 18:34:34]

A simple IDL change. 

lgtm

[commit-bot: I haz the power, 2017-01-10 18:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:48:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Raymond Toy, 2017-01-10 21:46:37]

On 2017/01/10 18:34:34, hongchan wrote:
> A simple IDL change. 
> 
> lgtm

PTAL again.  The removal wasn't actually complete. I have no idea why it
compiled fine on my linux box.

[hongchan, 2017-01-10 21:53:11]

On 2017/01/10 21:46:37, Raymond Toy wrote:
> On 2017/01/10 18:34:34, hongchan wrote:
> > A simple IDL change. 
> > 
> > lgtm
> 
> PTAL again.  The removal wasn't actually complete. I have no idea why it
> compiled fine on my linux box.

Yeah, I missed that the actual impl code does the inheritance. 

Still - lgtm

[Raymond Toy, 2017-01-11 21:37:48]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 21:38:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2017-01-11 21:39:22]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2017-01-11 21:39:23]

tkent: PTAL as API Owner

Just removing AudioSourceNode which was never part of the class hierarchy in the
WebAudio spec.

I didn't write an intent for this.  Should I?

[commit-bot: I haz the power, 2017-01-11 23:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:07:34]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-01-11 23:17:34]

On 2017/01/11 at 21:39:23, rtoy wrote:
> tkent: PTAL as API Owner
> 
> Just removing AudioSourceNode which was never part of the class hierarchy in
the WebAudio spec.
> 
> I didn't write an intent for this.  Should I?

If GitHub search and HTTP archive prove that AudioSourceNode is not used at all,
I think intent-to-remove isn't necessary.

[Raymond Toy, 2017-01-12 16:15:21]

On 2017/01/11 23:17:34, tkent wrote:
> On 2017/01/11 at 21:39:23, rtoy wrote:
> > tkent: PTAL as API Owner
> > 
> > Just removing AudioSourceNode which was never part of the class hierarchy in
> the WebAudio spec.
> > 
> > I didn't write an intent for this.  Should I?
> 
> If GitHub search and HTTP archive prove that AudioSourceNode is not used at
all,
> I think intent-to-remove isn't necessary.

Heh.  There are 20k+ hits on github. I didn't check them all, but, as hongchan@
says, these are all probably libraries that mechanically extract the info from
our IDL files.  I checked on Firefox and MediaElementAudioSourceNode doesn't
have AudioSourceNode in the prototype chain.

I'll write up a short intent in a bit and update the description with the
necessary information.
in_reply_to: 5703128158568448

[Raymond Toy, 2017-01-12 22:17:23]

Description was changed from

==========
Remove AudioSourceNode class

The MediaElementAudioSourceNode and MediaStreamAudioSourceNode were
specified to be derived from an AudioSourceNode.  This is not part of
the spec; these nodes are derived from AudioNode.  This was only
visible in the prototype chain for these classes.  The AudioSourceNode
is otherwise invisible to the user; it is not constructible and has no
properties.

Thus, remove the AudioSourceNode class.

BUG=663818
TEST=none
==========

to

==========
Remove AudioSourceNode class

The MediaElementAudioSourceNode and MediaStreamAudioSourceNode were
implemented as deriving from an AudioSourceNode.  This is not part of
the spec; these nodes are derived from AudioNode.  This was only
visible in the prototype chain for these classes.  The AudioSourceNode
is otherwise invisible to the user; it is not constructible and has no
properties.

Thus, remove the AudioSourceNode class.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/D-QJm9GCisc/gSCZwIrf...

BUG=663818
TEST=none
==========

[Raymond Toy, 2017-01-19 23:11:51]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-01-19 23:11:52]

Intent approved.

[Raymond Toy, 2017-01-19 23:11:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2621923003/#ps80001
(title: "Update BUILD.gn for removed file")

[Raymond Toy, 2017-01-19 23:12:16]

The CQ bit was unchecked by rtoy@chromium.org

[tkent, 2017-01-19 23:12:49]

lgtm

[Raymond Toy, 2017-01-23 16:08:10]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:08:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 16:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:09:34]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-01-23 16:37:13]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-01-23 16:37:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2621923003/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-23 16:37:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 16:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:38:54]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED, no build URL)

[Raymond Toy, 2017-01-23 18:54:55]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-23 18:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 19:36:32]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485197695251160,
"parent_rev": "69b49a8ebcb7b1efddf89262b0ca36a300d756a5", "commit_rev":
"717012126c57dfe596b6562f9ad17f2a7e537a5b"}

[commit-bot: I haz the power, 2017-01-23 19:37:04]

Description was changed from

==========
Remove AudioSourceNode class

The MediaElementAudioSourceNode and MediaStreamAudioSourceNode were
implemented as deriving from an AudioSourceNode.  This is not part of
the spec; these nodes are derived from AudioNode.  This was only
visible in the prototype chain for these classes.  The AudioSourceNode
is otherwise invisible to the user; it is not constructible and has no
properties.

Thus, remove the AudioSourceNode class.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/D-QJm9GCisc/gSCZwIrf...

BUG=663818
TEST=none
==========

to

==========
Remove AudioSourceNode class

The MediaElementAudioSourceNode and MediaStreamAudioSourceNode were
implemented as deriving from an AudioSourceNode.  This is not part of
the spec; these nodes are derived from AudioNode.  This was only
visible in the prototype chain for these classes.  The AudioSourceNode
is otherwise invisible to the user; it is not constructible and has no
properties.

Thus, remove the AudioSourceNode class.

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/D-QJm9GCisc/gSCZwIrf...

BUG=663818
TEST=none

Review-Url: https://codereview.chromium.org/2621923003
Cr-Commit-Position: refs/heads/master@{#445433}
Committed:
https://chromium.googlesource.com/chromium/src/+/717012126c57dfe596b6562f9ad1...
==========

[commit-bot: I haz the power, 2017-01-23 19:37:06]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/717012126c57dfe596b6562f9ad1...