Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/installer/util/product.h

Issue 2621923002: Product cleanups in the wake of multi-install removal. (Closed)
Patch Set: sync to position 442831 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/google_update_util.cc ('k') | chrome/installer/util/product.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/product.h
diff --git a/chrome/installer/util/product.h b/chrome/installer/util/product.h
index 0e384303980af98adccc8b54d393e63b8076930c..231c0bbcf78c00cb5e9ba35e15ea0c200d4268b7 100644
--- a/chrome/installer/util/product.h
+++ b/chrome/installer/util/product.h
@@ -8,8 +8,6 @@
#include <stdint.h>
#include <memory>
-#include <set>
-#include <string>
#include <vector>
#include "base/macros.h"
@@ -24,8 +22,6 @@ class CommandLine;
namespace installer {
-class ChannelInfo;
-class MasterPreferences;
class Product;
class ProductOperations;
@@ -44,27 +40,10 @@ class Product {
~Product();
- void InitializeFromPreferences(const MasterPreferences& prefs);
-
- void InitializeFromUninstallCommand(
- const base::CommandLine& uninstall_command);
-
BrowserDistribution* distribution() const {
return distribution_;
}
- bool HasOption(const std::wstring& option) const {
- return options_.find(option) != options_.end();
- }
-
- // Returns true if the set of options is mutated by this operation.
- bool SetOption(const std::wstring& option, bool set) {
- if (set)
- return options_.insert(option).second;
- else
- return options_.erase(option) != 0;
- }
-
// Launches Chrome without waiting for it to exit.
bool LaunchChrome(const base::FilePath& application_path) const;
@@ -92,9 +71,6 @@ class Product {
// See ProductOperations::AppendRenameFlags.
void AppendRenameFlags(base::CommandLine* command_line) const;
- // See Productoperations::SetChannelFlags.
- bool SetChannelFlags(bool set, ChannelInfo* channel_info) const;
-
// See ProductOperations::AddDefaultShortcutProperties.
void AddDefaultShortcutProperties(
const base::FilePath& target_exe,
@@ -111,7 +87,6 @@ class Product {
BrowserDistribution* const distribution_;
const std::unique_ptr<ProductOperations> operations_;
- std::set<std::wstring> options_;
private:
DISALLOW_COPY_AND_ASSIGN(Product);
« no previous file with comments | « chrome/installer/util/google_update_util.cc ('k') | chrome/installer/util/product.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698