CSS Transitions: Fix flaky interrupted-all-transition.html

CSS Transitions: Fix flaky interrupted-all-transition.html

We rAF until the property has changed, instead of using setTimeout.

BUG=248938
Review-Url: https://codereview.chromium.org/2621853002
Cr-Commit-Position: refs/heads/master@{#442842}
Committed: https://chromium.googlesource.com/chromium/src/+/63a5b25a302ad5868c230655e75b94d87be6d894

[Eric Willigers, 2017-01-10 01:38:00]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-10 08:42:42]

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html
(right):

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html:60:
assert_less_than(parseFloat(currentLeft), parseFloat(previousLeft));
We should see progress after a single raf.

[Eric Willigers, 2017-01-11 03:47:22]

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html
(right):

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html:60:
assert_less_than(parseFloat(currentLeft), parseFloat(previousLeft));
On 2017/01/10 08:42:42, alancutter wrote:
> We should see progress after a single raf.

Ideally we would.
See https://bugs.chromium.org/p/chromium/issues/detail?id=679981

[alancutter (OOO until 2018), 2017-01-11 04:17:29]

lgtm

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html
(right):

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html:35:
function waitForProgress() {
Please link to bug here as explanation.

[Eric Willigers, 2017-01-11 06:07:47]

Patchset #2 (id:20001) has been deleted

[Eric Willigers, 2017-01-11 06:11:41]

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html
(right):

https://codereview.chromium.org/2621853002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/interrupted-all-transition.html:35:
function waitForProgress() {
On 2017/01/11 04:17:29, alancutter wrote:
> Please link to bug here as explanation.

Done.

[Eric Willigers, 2017-01-11 06:12:29]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-01-11 06:12:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2621853002/#ps40001
(title: "link to bug")

[commit-bot: I haz the power, 2017-01-11 06:12:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:14:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484115149158250,
"parent_rev": "e71e4c5f1355e8937d59728476ef1e1eef170b06", "commit_rev":
"63a5b25a302ad5868c230655e75b94d87be6d894"}

[commit-bot: I haz the power, 2017-01-11 10:15:12]

Description was changed from

==========
CSS Transitions: Fix flaky interrupted-all-transition.html

We rAF until the property has changed, instead of using setTimeout.

BUG=248938
==========

to

==========
CSS Transitions: Fix flaky interrupted-all-transition.html

We rAF until the property has changed, instead of using setTimeout.

BUG=248938

Review-Url: https://codereview.chromium.org/2621853002
Cr-Commit-Position: refs/heads/master@{#442842}
Committed:
https://chromium.googlesource.com/chromium/src/+/63a5b25a302ad5868c230655e75b...
==========

[commit-bot: I haz the power, 2017-01-11 10:15:12]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/63a5b25a302ad5868c230655e75b...