Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2621843003: Removing ServerWindowCompositorFrameSinkManager::ShouldDraw() (Closed)

Created:
3 years, 11 months ago by sadrul
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing ServerWindowCompositorFrameSinkManager::ShouldDraw() With underlay surfaces unused/going away, ServerWindowCompositorFrameSinkManager should always draw. This is from mfomitchev@'s 2612113002 TBR=tsepez@ for mojom code deletion (original CL had approval) BUG=NONE Review-Url: https://codereview.chromium.org/2621843003 Cr-Commit-Position: refs/heads/master@{#442497} Committed: https://chromium.googlesource.com/chromium/src/+/6aef51529eeeb3a2105a7562cf96c0788698f69f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -34 lines) Patch
M ash/mus/root_window_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/interfaces/mus_constants.mojom View 1 chunk +1 line, -6 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.h View 2 chunks +0 lines, -12 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sadrul
Previously reviewed in https://codereview.chromium.org/2612113002/. This is the exact same CL, but the original CL does ...
3 years, 11 months ago (2017-01-10 01:30:46 UTC) #4
sky
LGTM
3 years, 11 months ago (2017-01-10 04:08:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621843003/1
3 years, 11 months ago (2017-01-10 05:17:31 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 05:28:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6aef51529eeeb3a2105a7562cf96...

Powered by Google App Engine
This is Rietveld 408576698