rlz: get rid of the call to AppendHeaderIfMissing()

rlz: get rid of the call to AppendHeaderIfMissing()

When |rlz_string| is non-empty, we can build the header and simply
return it ourselves.

This will help us to fix the Darin's TODO in HttpUtil to remove
HasHeader() method.

BUG=None
TEST=components_unittests
R=mmenke@chromium.org,rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2621843002
Cr-Commit-Position: refs/heads/master@{#442616}
Committed: https://chromium.googlesource.com/chromium/src/+/451a66360d2cea9161108d8ebf7f19555e6a07a0

[tfarina, 2017-01-10 00:38:27]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:39:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:48:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tfarina, 2017-01-10 07:26:45]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 07:26:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 07:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 07:36:23]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[tfarina, 2017-01-10 10:08:10]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 10:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 10:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 10:37:54]

Dry run: This issue passed the CQ dry run.

[Roger Tawa OOO till Jul 10th, 2017-01-10 15:04:31]

lgtm

[mmenke, 2017-01-10 16:10:06]

On 2017/01/10 15:04:31, Roger Tawa (OOO until Jan 9th) wrote:
> lgtm

LGTM as well

[tfarina, 2017-01-10 17:09:49]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2017-01-10 17:10:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 17:14:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484068189066440,
"parent_rev": "2d67dc211444eba23d7c441f590f2018acea53fa", "commit_rev":
"451a66360d2cea9161108d8ebf7f19555e6a07a0"}

[commit-bot: I haz the power, 2017-01-10 17:14:28]

Description was changed from

==========
rlz: get rid of the call to AppendHeaderIfMissing()

When |rlz_string| is non-empty, we can build the header and simply
return it ourselves.

This will help us to fix the Darin's TODO in HttpUtil to remove
HasHeader() method.

BUG=None
TEST=components_unittests
R=mmenke@chromium.org,rogerta@chromium.org
==========

to

==========
rlz: get rid of the call to AppendHeaderIfMissing()

When |rlz_string| is non-empty, we can build the header and simply
return it ourselves.

This will help us to fix the Darin's TODO in HttpUtil to remove
HasHeader() method.

BUG=None
TEST=components_unittests
R=mmenke@chromium.org,rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2621843002
Cr-Commit-Position: refs/heads/master@{#442616}
Committed:
https://chromium.googlesource.com/chromium/src/+/451a66360d2cea9161108d8ebf7f...
==========

[commit-bot: I haz the power, 2017-01-10 17:14:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/451a66360d2cea9161108d8ebf7f...