Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4826)

Unified Diff: chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

Issue 2621793003: [Chromecast] Restore CastDevToolsManagerDelegateTest (Closed)
Patch Set: Add missing BUILD.gn dependencies Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
diff --git a/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc b/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
index 879d0c9ec33d2660f4d4992ddc95c08f30480674..f11c7bd7b03e871bea45c6f40bd07bbafe0431e6 100644
--- a/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
+++ b/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
@@ -15,6 +15,7 @@
#include "content/public/test/test_renderer_host.h"
#include "content/public/test/web_contents_tester.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/gl/test/gl_surface_test_support.h"
namespace chromecast {
namespace shell {
@@ -28,6 +29,7 @@ class CastDevToolsManagerDelegateTest
~CastDevToolsManagerDelegateTest() override {}
void SetUp() override {
+ gl::GLSurfaceTestSupport::InitializeOneOff();
initializer_ = base::MakeUnique<content::TestContentClientInitializer>();
content::RenderViewHostTestHarness::SetUp();
devtools_manager_delegate_ =
@@ -53,26 +55,24 @@ class CastDevToolsManagerDelegateTest
DISALLOW_COPY_AND_ASSIGN(CastDevToolsManagerDelegateTest);
};
-// TODO(derekjchow): Make the tests pass on cast testbots.
-// crbug.com/665118
-TEST_F(CastDevToolsManagerDelegateTest, DISABLED_TestSingletonGetter) {
+TEST_F(CastDevToolsManagerDelegateTest, TestSingletonGetter) {
EXPECT_EQ(devtools_manager_delegate_.get(),
CastDevToolsManagerDelegate::GetInstance());
}
-TEST_F(CastDevToolsManagerDelegateTest, DISABLED_NoWebContents) {
+TEST_F(CastDevToolsManagerDelegateTest, NoWebContents) {
EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,
base::Unretained(this), WebContentsSet())));
}
-TEST_F(CastDevToolsManagerDelegateTest, DISABLED_DisabledWebContents) {
+TEST_F(CastDevToolsManagerDelegateTest, DisabledWebContents) {
EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,
base::Unretained(this), WebContentsSet())));
}
-TEST_F(CastDevToolsManagerDelegateTest, DISABLED_EnabledWebContents) {
+TEST_F(CastDevToolsManagerDelegateTest, EnabledWebContents) {
devtools_manager_delegate_->EnableWebContentsForDebugging(web_contents());
WebContentsSet enabled_web_contents({web_contents()});
EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
« no previous file with comments | « chromecast/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698