Landing Recent QUIC changes until Jan 6 14:42:13 2017

Landing Recent QUIC changes until Jan 6 14:42:13 2017

There are no flags to be updated.

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation.

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

Move SendPublicReset from private to a protected virtual function.

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof failed. Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2621793002
Cr-Commit-Position: refs/heads/master@{#442425}
Committed: https://chromium.googlesource.com/chromium/src/+/c95c89bebf9003e535e609060cd19849ca22a19f

[danzh1, 2017-01-09 21:38:49]

Description was changed from

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413

Simplify a string allocation and append into a single allocation

n/a (test tools)

Merge internal change: 143728589

move SendPublicReset from private to a protected virtual function

Merge internal change: 143582614

include order


include order


add copy right


add .cc file


Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof
failed.

Fix b/33916924, an occasional crash on bandaid.  Not flag-protected.

Merge internal change: 143447261

R=jri@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

move SendPublicReset from private to a protected virtual function

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof
failed.

Fix b/33916924, an occasional crash on bandaid.  Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=
==========

[danzh1, 2017-01-09 21:39:24]

Description was changed from

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

move SendPublicReset from private to a protected virtual function

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof
failed.

Fix b/33916924, an occasional crash on bandaid.  Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

There are no flags to be updated.

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

move SendPublicReset from private to a protected virtual function

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof
failed.

Fix b/33916924, an occasional crash on bandaid.  Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=
==========

[danzh1, 2017-01-09 21:41:40]

Description was changed from

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

There are no flags to be updated.

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

move SendPublicReset from private to a protected virtual function

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof
failed.

Fix b/33916924, an occasional crash on bandaid.  Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

There are no flags to be updated.

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation.

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

Move SendPublicReset from private to a protected virtual function.

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof failed.
Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=
==========

[danzh1, 2017-01-09 21:42:32]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 21:43:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:12:04]

Dry run: This issue passed the CQ dry run.

[Jana, 2017-01-10 00:05:05]

The CQ bit was checked by jri@chromium.org

[Jana, 2017-01-10 00:05:06]

lgtm

[commit-bot: I haz the power, 2017-01-10 00:05:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:38:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484006705536580, "parent_rev":
"26e30ced5c0018ccada8063ee8b0bcd2fac293af", "commit_rev":
"c95c89bebf9003e535e609060cd19849ca22a19f"}

[commit-bot: I haz the power, 2017-01-10 00:38:44]

Description was changed from

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

There are no flags to be updated.

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation.

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

Move SendPublicReset from private to a protected virtual function.

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof failed.
Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=
==========

to

==========
Landing Recent QUIC changes until Jan 6 14:42:13 2017

There are no flags to be updated.

Deprecate FLAGS_quic_export_rej_for_all_rejects.

Merge internal change: 143769413
https://codereview.chromium.org/2621753002/

Simplify a string allocation and append into a single allocation.

n/a (test tools)

Merge internal change: 143728589
https://codereview.chromium.org/2621733002/

Move SendPublicReset from private to a protected virtual function.

Merge internal change: 143582614
https://codereview.chromium.org/2621573003/

Fix QUIC crash when ProofSource::GetProof fails

This CL fixes a crash in QuicCryptoServerConfig which occurs when
ProofSource::GetProof fails.  The situation occurs in
QuicCryptoServerConfig::EvaluateClientHello, when async codepaths are
disabled.  If the call to proof_source_->GetProof returns false, then we
set get_proof_failed to true and invoke
EvaluateClientHelloAfterGetProof.  However, that method (and
ValidateExpectedLeafCertificate, which it calls) assume that
signed_config->chain is populated, which may not be the case if GetProof failed.
Not flag-protected.

Merge internal change: 143447261
https://codereview.chromium.org/2626443002/

R=jri@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2621793002
Cr-Commit-Position: refs/heads/master@{#442425}
Committed:
https://chromium.googlesource.com/chromium/src/+/c95c89bebf9003e535e609060cd1...
==========

[commit-bot: I haz the power, 2017-01-10 00:38:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c95c89bebf9003e535e609060cd1...