Make SSLClientSocketImpl::SSLContext a leaky singleton.

Make SSLClientSocketImpl::SSLContext a leaky singleton.

There is no good reason to delete SSLClientSocketImpl::SSLContext
on shutdown. See discussion:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OLS4JSZvowI/arzfUZEEBwAJ

BUG=

Review-Url: https://codereview.chromium.org/2621743004
Cr-Commit-Position: refs/heads/master@{#444798}
Committed: https://chromium.googlesource.com/chromium/src/+/33e7c3c5440304b63c1c6804b73addfe2d8ca328

[fdoray, 2017-01-10 13:38:30]

Description was changed from

==========
Make SSLClientSocketImpl::SSLContext a leaky singleton.

BUG=
==========

to

==========
Make SSLClientSocketImpl::SSLContext a leaky singleton.

There is no good reason to delete SSLClientSocketImpl::SSLContext
on shutdown. See discussion:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OLS4JSZvowI/arzfU...

BUG=
==========

[fdoray, 2017-01-10 13:38:47]

fdoray@chromium.org changed reviewers:
+ jri@chromium.org

[fdoray, 2017-01-10 13:38:48]

PTAL

[fdoray, 2017-01-12 20:56:40]

fdoray@chromium.org changed reviewers:
+ rch@chromium.org

[fdoray, 2017-01-12 20:56:41]

jri@: ping

+rch@ in case jri@ is not available

[fdoray, 2017-01-19 16:25:55]

fdoray@chromium.org changed reviewers:
+ mmenke@chromium.org

[fdoray, 2017-01-19 16:25:56]

ping

+mmenke@ in case other owners are not available (no reply in 6 days)

[mmenke, 2017-01-19 16:38:37]

mmenke@chromium.org changed reviewers:
+ davidben@chromium.org

[mmenke, 2017-01-19 16:38:38]

[+davidben]:  Mind reviewing this?  I have no idea what SSLConext is, or what it
does.  It also lacks comments explaining this.

Hrm...How many network stack team members does it take to review a two-line CL? 
:)

[fdoray, 2017-01-19 16:58:57]

On 2017/01/19 16:38:38, mmenke wrote:
> [+davidben]:  Mind reviewing this?  I have no idea what SSLConext is, or what
it
> does.  It also lacks comments explaining this.
> 
> Hrm...How many network stack team members does it take to review a two-line
CL? 
> :)

With this CL, the SSLClientSocketImpl::SSLContext instance is not destroyed on
shutdown. This is generally desirable
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OLS4JSZvowI/arzfU...

[Jana, 2017-01-19 17:03:16]

On 2017/01/19 16:58:57, fdoray wrote:
> On 2017/01/19 16:38:38, mmenke wrote:
> > [+davidben]:  Mind reviewing this?  I have no idea what SSLConext is, or
what
> it
> > does.  It also lacks comments explaining this.
> > 
> > Hrm...How many network stack team members does it take to review a two-line
> CL? 
> > :)
> 
> With this CL, the SSLClientSocketImpl::SSLContext instance is not destroyed on
> shutdown. This is generally desirable
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OLS4JSZvowI/arzfU...

Apologies for not responding for a while -- I don't have enough context for this
CL as well, so davidben@ is probably best?

[davidben, 2017-01-19 17:23:41]

lgtm.

This thing shouldn't be a singleton to begin with and needs to be an object
hanging off the HttpNetworkSession or so, but, in the meantime, this change
makes sense.

[fdoray, 2017-01-19 17:27:36]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-01-19 17:27:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 18:37:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484846856077030, "parent_rev":
"662473565c1dd46ec06077c8e6519c195814b46d", "commit_rev":
"33e7c3c5440304b63c1c6804b73addfe2d8ca328"}

[commit-bot: I haz the power, 2017-01-19 18:37:59]

Description was changed from

==========
Make SSLClientSocketImpl::SSLContext a leaky singleton.

There is no good reason to delete SSLClientSocketImpl::SSLContext
on shutdown. See discussion:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OLS4JSZvowI/arzfU...

BUG=
==========

to

==========
Make SSLClientSocketImpl::SSLContext a leaky singleton.

There is no good reason to delete SSLClientSocketImpl::SSLContext
on shutdown. See discussion:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/OLS4JSZvowI/arzfU...

BUG=

Review-Url: https://codereview.chromium.org/2621743004
Cr-Commit-Position: refs/heads/master@{#444798}
Committed:
https://chromium.googlesource.com/chromium/src/+/33e7c3c5440304b63c1c6804b73a...
==========

[commit-bot: I haz the power, 2017-01-19 18:38:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33e7c3c5440304b63c1c6804b73a...