Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2621733004: RTCPeerConnection.getStats whitelist updated due to recent spec changes. (Closed)

Created:
3 years, 11 months ago by hbos_chromium
Modified:
3 years, 11 months ago
Reviewers:
hta - Chromium
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RTCPeerConnection.getStats whitelist updated due to recent spec changes. RTCRTPStreamStats.mediaTrackId renamed trackId: https://github.com/w3c/webrtc-stats/issues/113#issuecomment-271548836 RTCMediaStreamTrackStats.kind added: https://github.com/w3c/webrtc-stats/pull/127 RTCPeerConnectionStats.dataChannels[Opened/Closed/Requested/Accepted] added: https://github.com/w3c/webrtc-stats/pull/125/files RTCTransportStats.activeConnection replaced by dtlsState: https://github.com/w3c/webrtc-stats/pull/122/files BUG=chromium:657854, chromium:659137, chromium:679741, chromium:653873, chromium:627816 Review-Url: https://codereview.chromium.org/2621733004 Cr-Commit-Position: refs/heads/master@{#443879} Committed: https://chromium.googlesource.com/chromium/src/+/d28adf3696a330580b5fb705531322ca4f9f3297

Patch Set 1 #

Total comments: 2

Patch Set 2 : RTCPeerConnectionStats updated after spec changed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/test/data/webrtc/peerconnection_getstats.js View 1 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
hbos_chromium
Please take a look, hta. https://codereview.chromium.org/2621733004/diff/1/chrome/test/data/webrtc/peerconnection_getstats.js File chrome/test/data/webrtc/peerconnection_getstats.js (right): https://codereview.chromium.org/2621733004/diff/1/chrome/test/data/webrtc/peerconnection_getstats.js#newcode101 chrome/test/data/webrtc/peerconnection_getstats.js:101: dataChannelsSignaledClosed: 'number', Note spelling ...
3 years, 11 months ago (2017-01-10 14:56:58 UTC) #4
hbos_chromium
Updated RTCPeerConnectionStats after spec changed again. https://codereview.chromium.org/2621733004/diff/1/chrome/test/data/webrtc/peerconnection_getstats.js File chrome/test/data/webrtc/peerconnection_getstats.js (right): https://codereview.chromium.org/2621733004/diff/1/chrome/test/data/webrtc/peerconnection_getstats.js#newcode101 chrome/test/data/webrtc/peerconnection_getstats.js:101: dataChannelsSignaledClosed: 'number', On ...
3 years, 11 months ago (2017-01-11 11:10:15 UTC) #10
hta - Chromium
lgtm
3 years, 11 months ago (2017-01-16 11:45:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621733004/20001
3 years, 11 months ago (2017-01-16 11:46:17 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 12:56:58 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d28adf3696a330580b5fb7055313...

Powered by Google App Engine
This is Rietveld 408576698