Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 262173002: Reduce method names converted to upper case via uppercaseKnownHTTPMethod() (Closed)

Created:
6 years, 7 months ago by caitp (gmail)
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Reduce method names converted to upper case via uppercaseKnownHTTPMethod() Per http://xhr.spec.whatwg.org/#dom-xmlhttprequest-open, as of 5/4/2014, only the DELETE, GET, HEAD, OPTIONS, POST and PUT methods ought to be converted to upper case. Correcting this behaviour passes two additional WPT suites. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -10 lines) Patch
A LayoutTests/http/tests/xmlhttprequest/method-name.cgi View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/method-names.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/method-names-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caitp (gmail)
Patch adjusts XMLHttpRequest to convert only DELETE, GET, HEAD, OPTIONS, POST and PUT requests to ...
6 years, 7 months ago (2014-05-04 21:21:42 UTC) #1
adamk
Thanks for the patch, but I think abarth is likely a better reviewer than me ...
6 years, 7 months ago (2014-05-05 18:39:06 UTC) #2
caitp (gmail)
6 years, 7 months ago (2014-05-05 18:41:33 UTC) #3
On 2014/05/05 18:39:06, adamk wrote:
> Thanks for the patch, but I think abarth is likely a better reviewer than me
> (XHR is not my specialty).
> 
> Also, I don't see your email address in
> http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS. Looking at the review
> on your last commit (with tkent, https://codereview.chromium.org/132483006),
it
> sounds like you have signed the CLA but simply haven't added yourself to the
> AUTHORS file. Please do so, as it makes it easier for reviewers to handle your
> patches.

Oh sorry, you were the suggested owner gclient gave me, but most of the file
seems to predate the blink fork anyways, so I wasn't sure who would be a good
reviewer.

I will try to get myself added to authors

Powered by Google App Engine
This is Rietveld 408576698