Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 132483006: EmailInputType should set typeMismatch=true for emails with domain labels beginning or ending with … (Closed)

Created:
6 years, 11 months ago by caitp (gmail)
Modified:
6 years, 10 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

EmailInputType should set typeMismatch=true for emails with domain labels beginning or ending with a hyphen Emails should be invalidated if they contain these domain labels (in accordance with RFC1035 and the HTML5 draft http://www.w3.org/TR/html5/forms.html#valid-e-mail-address, as well as Firefox) BUG=338141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M LayoutTests/fast/forms/ValidityState-typeMismatch-email-expected.txt View 6 chunks +8 lines, -6 lines 0 comments Download
M LayoutTests/fast/forms/resources/ValidityState-typeMismatch-email.js View 6 chunks +8 lines, -6 lines 0 comments Download
M Source/core/html/forms/EmailInputType.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
The code looks ok. Did you sign Individual Contributor License Agreement? Please refer to http://dev.chromium.org/developers/contributing-code ...
6 years, 11 months ago (2014-01-28 07:47:38 UTC) #1
caitp (gmail)
On 2014/01/28 07:47:38, tkent wrote: > The code looks ok. > > Did you sign ...
6 years, 10 months ago (2014-01-28 14:09:40 UTC) #2
tkent
On 2014/01/28 14:09:40, caitp wrote: > On 2014/01/28 07:47:38, tkent wrote: > > The code ...
6 years, 10 months ago (2014-01-28 23:01:36 UTC) #3
tkent
lgtm
6 years, 10 months ago (2014-01-28 23:01:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitpotter88@gmail.com/132483006/1
6 years, 10 months ago (2014-01-28 23:02:49 UTC) #5
commit-bot: I haz the power
Change committed as 165978
6 years, 10 months ago (2014-01-29 00:16:20 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 00:16:47 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698