Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2621713002: Adding swarming documentation to perf sheriff docs. (Closed)

Created:
3 years, 11 months ago by eyaich1
Modified:
3 years, 11 months ago
Reviewers:
sullivan, martiniss
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding swarming documentation to perf sheriff docs. BUG=chromium:676490 Review-Url: https://codereview.chromium.org/2621713002 Cr-Commit-Position: refs/heads/master@{#442320} Committed: https://chromium.googlesource.com/chromium/src/+/c84c810a216c89c09abdcdf74682984aff63c722

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge and review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -2 lines) Patch
M tools/perf/docs/perf_bot_sheriffing.md View 1 3 chunks +121 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
eyaich1
3 years, 11 months ago (2017-01-09 17:47:25 UTC) #2
sullivan
lgtm
3 years, 11 months ago (2017-01-09 18:05:35 UTC) #3
martiniss
lgtm https://codereview.chromium.org/2621713002/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2621713002/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode274 tools/perf/docs/perf_bot_sheriffing.md:274: 1. Bot might be down, check the chrome-perf ...
3 years, 11 months ago (2017-01-09 18:23:55 UTC) #4
eyaich1
thanks! https://codereview.chromium.org/2621713002/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2621713002/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode274 tools/perf/docs/perf_bot_sheriffing.md:274: 1. Bot might be down, check the chrome-perf ...
3 years, 11 months ago (2017-01-09 18:44:31 UTC) #5
eyaich1
thanks! https://codereview.chromium.org/2621713002/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2621713002/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode274 tools/perf/docs/perf_bot_sheriffing.md:274: 1. Bot might be down, check the chrome-perf ...
3 years, 11 months ago (2017-01-09 18:44:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621713002/20001
3 years, 11 months ago (2017-01-09 18:45:47 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 20:09:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c84c810a216c89c09abdcdf74682...

Powered by Google App Engine
This is Rietveld 408576698