Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2621693003: Convert camera vid and pid to lower case (Closed)

Created:
3 years, 11 months ago by henryhsu
Modified:
3 years, 11 months ago
Reviewers:
wuchengli, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert camera vid and pid to lower case BUG=673210 TEST=open camera app and see the vid/pid is converted to lower case in log Review-Url: https://codereview.chromium.org/2621693003 Cr-Commit-Position: refs/heads/master@{#442823} Committed: https://chromium.googlesource.com/chromium/src/+/1f8e11ba4fa17aa707f9a8a4a70807745faa3f4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M media/capture/video/linux/camera_facing_chromeos.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
henryhsu
PTAL
3 years, 11 months ago (2017-01-10 10:25:39 UTC) #2
Pawel Osciak
lgtm
3 years, 11 months ago (2017-01-11 03:48:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621693003/1
3 years, 11 months ago (2017-01-11 05:05:11 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 06:20:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f8e11ba4fa17aa707f9a8a4a708...

Powered by Google App Engine
This is Rietveld 408576698