Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2621663002: Revert of GetTimeToCallback() returns estimated time to callback. (Closed)

Created:
3 years, 11 months ago by gab
Modified:
3 years, 11 months ago
CC:
chromium-reviews, chirantan+watch_chromium.org, vmpstr+watch_chromium.org, dkalin, kumarniranjan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GetTimeToCallback() returns estimated time to callback. (patchset #5 id:80001 of https://codereview.chromium.org/2557663002/ ) Reason for revert: Removing Timer::GetTimeToCallback() as discussed post commit on CL introducing it. Original issue's description: > GetTimeToCallback() returns estimated time to callback. > > BUG=none > TEST=unit tests > > Committed: https://crrev.com/ceb6d93b695b137481f050f5b967d882a77b7398 > Cr-Commit-Position: refs/heads/master@{#439174} TBR=mark@chromium.org,drcrash@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Review-Url: https://codereview.chromium.org/2621663002 Cr-Commit-Position: refs/heads/master@{#442290} Committed: https://chromium.googlesource.com/chromium/src/+/f115664eb4b48daa35590c365d7db577f3514c0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -80 lines) Patch
M base/timer/timer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/timer/timer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M base/timer/timer_unittest.cc View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
gab
Created Revert of GetTimeToCallback() returns estimated time to callback.
3 years, 11 months ago (2017-01-09 16:17:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621663002/1
3 years, 11 months ago (2017-01-09 16:17:31 UTC) #3
Mark Mentovai
LGTM
3 years, 11 months ago (2017-01-09 17:32:13 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:03:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f115664eb4b48daa35590c365d7d...

Powered by Google App Engine
This is Rietveld 408576698