Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

Currently cc::SurfaceLayer::SetSurfaceInfo takes in
stretch_content_to_fill_bounds which doesn't belong there because
the purpose of this method is to set SurfaceInfo and only SurfaceInfo.
A separate method called SetStretchContentToFillBounds is created
instead.

TBR=darin@chromium.org

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2621653002
Cr-Commit-Position: refs/heads/master@{#442414}
Committed: https://chromium.googlesource.com/chromium/src/+/e8fd2e59b07fd42d8716675265d4b67419fcc726

[Saman Sami, 2017-01-09 16:10:06]

Description was changed from

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

BUG=675313
==========

to

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-09 16:15:40]

Description was changed from

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

Currently cc::SurfaceLayer::SetSurfaceInfo takes in
stretch_content_to_fill_bounds which doesn't belong there because
the purpose of this method is to set SurfaceInfo and only SurfaceInfo.
A separate method called SetStretchContentToFillBounds is created
instead.

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-01-09 16:15:40]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Saman Sami, 2017-01-09 16:15:45]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:16:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-09 16:17:34]

samans@chromium.org changed reviewers:
+ danakj@chromium.org

[Saman Sami, 2017-01-09 16:18:57]

samans@chromium.org changed reviewers:
+ xlai@chromium.org

[Fady Samuel, 2017-01-09 16:21:05]

lgtm

[commit-bot: I haz the power, 2017-01-09 16:36:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 16:36:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Saman Sami, 2017-01-09 16:42:26]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 16:42:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-09 18:56:27]

danakj: Please review all files.

[Saman Sami, 2017-01-09 19:05:42]

samans@chromium.org changed reviewers:
+ dglazkov@chromium.org

[Saman Sami, 2017-01-09 19:06:12]

samans@chromium.org changed reviewers:
+ piman@chromium.org

[Saman Sami, 2017-01-09 19:06:35]

samans@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[Saman Sami, 2017-01-09 19:06:57]

samans@chromium.org changed reviewers:
+ miguelg@chromium.org

[Saman Sami, 2017-01-09 19:09:11]

samans@chromium.org changed reviewers:
+ darin@chromium.org
- dglazkov@chromium.org, khushalsagar@chromium.org, miguelg@chromium.org,
piman@chromium.org

[Saman Sami, 2017-01-09 19:09:56]

Description was changed from

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

Currently cc::SurfaceLayer::SetSurfaceInfo takes in
stretch_content_to_fill_bounds which doesn't belong there because
the purpose of this method is to set SurfaceInfo and only SurfaceInfo.
A separate method called SetStretchContentToFillBounds is created
instead.

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

Currently cc::SurfaceLayer::SetSurfaceInfo takes in
stretch_content_to_fill_bounds which doesn't belong there because
the purpose of this method is to set SurfaceInfo and only SurfaceInfo.
A separate method called SetStretchContentToFillBounds is created
instead.

TBR=darin@chromium.org

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xlai (Olivia), 2017-01-09 19:15:21]

lgtm

[danakj, 2017-01-09 19:37:12]

https://codereview.chromium.org/2621653002/diff/20001/cc/layers/surface_layer.cc
File cc/layers/surface_layer.cc (right):

https://codereview.chromium.org/2621653002/diff/20001/cc/layers/surface_layer...
cc/layers/surface_layer.cc:79: UpdateDrawsContent(HasDrawableContent());
HasDrawableContent does not depend on stretch_content_to_fill_bounds_

https://codereview.chromium.org/2621653002/diff/20001/cc/layers/surface_layer.h
File cc/layers/surface_layer.h (right):

https://codereview.chromium.org/2621653002/diff/20001/cc/layers/surface_layer...
cc/layers/surface_layer.h:29: // When stretch_content_to_fill_bounds is true,
scale is unused.
I think this comment doesn't quite work now, which scale does it mean? Can you
rewrite this?

https://codereview.chromium.org/2621653002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp
(right):

https://codereview.chromium.org/2621653002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp:98:
surfaceLayer->SetStretchContentToFillBounds(true);
you could do this once when the layer is created instead of every frame

[commit-bot: I haz the power, 2017-01-09 19:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:37:29]

Dry run: This issue passed the CQ dry run.

[Saman Sami, 2017-01-09 20:21:19]

PTAL

[Saman Sami, 2017-01-09 20:21:28]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 20:22:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-09 20:23:33]

LGTM

[danakj, 2017-01-09 20:23:45]

That's a great comment btw gj

[commit-bot: I haz the power, 2017-01-09 22:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:40:29]

Dry run: This issue passed the CQ dry run.

[Saman Sami, 2017-01-09 23:59:39]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-01-09 23:59:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, xlai@chromium.org
Link to the patchset: https://codereview.chromium.org/2621653002/#ps40001
(title: "up")

[commit-bot: I haz the power, 2017-01-10 00:01:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:23:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484006379726170,
"parent_rev": "0f8b383bba59a8240c646a99fb0a5b2afc995d5d", "commit_rev":
"e8fd2e59b07fd42d8716675265d4b67419fcc726"}

[commit-bot: I haz the power, 2017-01-10 00:23:46]

Description was changed from

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

Currently cc::SurfaceLayer::SetSurfaceInfo takes in
stretch_content_to_fill_bounds which doesn't belong there because
the purpose of this method is to set SurfaceInfo and only SurfaceInfo.
A separate method called SetStretchContentToFillBounds is created
instead.

TBR=darin@chromium.org

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove stretch_content_to_fill_bounds from cc::SurfaceLayer::SetSurfaceInfo

Currently cc::SurfaceLayer::SetSurfaceInfo takes in
stretch_content_to_fill_bounds which doesn't belong there because
the purpose of this method is to set SurfaceInfo and only SurfaceInfo.
A separate method called SetStretchContentToFillBounds is created
instead.

TBR=darin@chromium.org

BUG=675313
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2621653002
Cr-Commit-Position: refs/heads/master@{#442414}
Committed:
https://chromium.googlesource.com/chromium/src/+/e8fd2e59b07fd42d8716675265d4...
==========

[commit-bot: I haz the power, 2017-01-10 00:23:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e8fd2e59b07fd42d8716675265d4...