Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2621583002: [crankshaft] Properly deal with null prototype. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Properly deal with null prototype. Don't assume that the prototype of an object is always a JSObject when inlining the known receiver map case for abstract relational comparison. BUG=chromium:679202 R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2621583002 Cr-Commit-Position: refs/heads/master@{#42123} Committed: https://chromium.googlesource.com/v8/v8/+/5f418c8a2d95620c8d328e1357e9373c74e685e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +5 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-679202.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-09 08:22:00 UTC) #1
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-09 08:26:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621583002/1
3 years, 11 months ago (2017-01-09 08:26:50 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 08:47:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5f418c8a2d95620c8d328e1357e9373c74e...

Powered by Google App Engine
This is Rietveld 408576698