Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2621553002: Properly test unset behavior of invalid registered property values (Closed)

Created:
3 years, 11 months ago by Timothy Loh
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly test unset behavior of invalid registered property values This patch fixes registered-property-cssom.html to properly test that invalid registered property values are computed as unset. The test was missing inherited values so the unset value was always resolving to the initial value. BUG=641877 Review-Url: https://codereview.chromium.org/2621553002 Cr-Commit-Position: refs/heads/master@{#442197} Committed: https://chromium.googlesource.com/chromium/src/+/eef2fbb63ea6f4d96cbc2f01f922f9122a453a77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/custom-properties/registered-property-cssom.html View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Timothy Loh
3 years, 11 months ago (2017-01-09 04:17:54 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2017-01-09 04:24:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621553002/1
3 years, 11 months ago (2017-01-09 04:25:47 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 05:21:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eef2fbb63ea6f4d96cbc2f01f922...

Powered by Google App Engine
This is Rietveld 408576698