Don't treat Esc like Cancel in the external protocol dialog on Views.

Don't treat Esc like Cancel in the external protocol dialog on Views.

By default, closing a dialog on Views using the Esc key behaves as if
the secondary button was pressed. In the external protocol handler, this
can create a state where the user inadvertently blocks external
protocol launching for a particular scheme with no way to allow them
again. This occurs when they tick the checkbox to always open links, but
then use Esc to close the dialog. Until UI to edit external protocol
settings is implemented, this permanently prevents any dialogs from
the page for that scheme.

This CL addresses part of the bug by ensuring that closing the external
protocol dialog without interacting with the buttons ignores the checkbox
state.

BUG=671658
Review-Url: https://codereview.chromium.org/2559783003
Cr-Commit-Position: refs/heads/master@{#441863}
(cherry picked from commit fc29407956cd9349e12be316b7f0007c9b2471ab)

Review-Url: https://codereview.chromium.org/2621513002 .
Cr-Commit-Position: refs/branch-heads/2924@{#697}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/124a59b333bd2fefa3b80501c877d0611bd8a7bf

[dominickn, 2017-01-08 22:57:20]

Description was changed from

==========
Don't treat Esc like Cancel in the external protocol dialog on Views.

By default, closing a dialog on Views using the Esc key behaves as if
the secondary button was pressed. In the external protocol handler, this
can create a state where the user inadvertently blocks external
protocol launching for a particular scheme with no way to allow them
again. This occurs when they tick the checkbox to always open links, but
then use Esc to close the dialog. Until UI to edit external protocol
settings is implemented, this permanently prevents any dialogs from
the page for that scheme.

This CL addresses part of the bug by ensuring that closing the external
protocol dialog without interacting with the buttons ignores the checkbox
state.

BUG=671658

Review-Url: https://codereview.chromium.org/2559783003
Cr-Commit-Position: refs/heads/master@{#441863}
(cherry picked from commit fc29407956cd9349e12be316b7f0007c9b2471ab)
==========

to

==========
Don't treat Esc like Cancel in the external protocol dialog on Views.

By default, closing a dialog on Views using the Esc key behaves as if
the secondary button was pressed. In the external protocol handler, this
can create a state where the user inadvertently blocks external
protocol launching for a particular scheme with no way to allow them
again. This occurs when they tick the checkbox to always open links, but
then use Esc to close the dialog. Until UI to edit external protocol
settings is implemented, this permanently prevents any dialogs from
the page for that scheme.

This CL addresses part of the bug by ensuring that closing the external
protocol dialog without interacting with the buttons ignores the checkbox
state.

BUG=671658

Review-Url: https://codereview.chromium.org/2559783003
Cr-Commit-Position: refs/heads/master@{#441863}
(cherry picked from commit fc29407956cd9349e12be316b7f0007c9b2471ab)

Review-Url: https://codereview.chromium.org/2621513002 .
Cr-Commit-Position: refs/branch-heads/2924@{#697}
Cr-Branched-From:
3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed:
https://chromium.googlesource.com/chromium/src/+/124a59b333bd2fefa3b80501c877...
==========

[dominickn, 2017-01-08 22:57:25]

Committed patchset #1 (id:1) manually as
124a59b333bd2fefa3b80501c877d0611bd8a7bf.