fixes #28236, generic methods should not cause warnings in Dart 1

fixes #28236, generic methods should not cause warnings in Dart 1

Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/816592a9417cd9e02be4fd8683961caed4e210b7

[Jennifer Messerly, 2017-01-07 01:41:51]

Description was changed from

==========
fixes #28236, generic methods should not cause warnings in Dart 1
==========

to

==========
fixes #28236, generic methods should not cause warnings in Dart 1

- instantiate universal functions in subtype tests
- instantiate universal functions in tear-offs
==========

[Jennifer Messerly, 2017-01-07 01:41:51]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com, lrn@google.com

[Jennifer Messerly, 2017-01-07 01:42:18]

Description was changed from

==========
fixes #28236, generic methods should not cause warnings in Dart 1

- instantiate universal functions in subtype tests
- instantiate universal functions in tear-offs
==========

to

==========
fixes #28236, generic methods should not cause warnings in Dart 1

Instantiate universal functions in subtype tests & tear-offs. Also updates the
status files and one Analyzer test that covered the tear-off type.
==========

[Jennifer Messerly, 2017-01-07 01:43:42]

Hi guys, here's the fix for: https://github.com/dart-lang/sdk/issues/28236

I was able to get a clean test run on:
./tools/test.py -cdart2analyzer -rnone -mrelease

and:

./tools/test.py --checked -mrelease pkg/analyzer

[Jennifer Messerly, 2017-01-07 01:46:34]

One thing of note here.

functions such as min: (num, num) -> num  will now have type (dynamic, dynamic)
-> dynamic. So that's weaker than it was before for static warning purposes. We
may want to instantiate to the bounds for these guys. It's a little awkward
because Dart1 type system instantiateToBounds uses dynamic, so perhaps we could
introduce something like instantiateFunctionTypeToBounds, which behaves similar
to Strong Mode's instantiateToBounds.

[Brian Wilkerson, 2017-01-07 15:40:28]

lgtm, thanks!

[Jennifer Messerly, 2017-01-09 20:46:26]

Description was changed from

==========
fixes #28236, generic methods should not cause warnings in Dart 1

Instantiate universal functions in subtype tests & tear-offs. Also updates the
status files and one Analyzer test that covered the tear-off type.
==========

to

==========
fixes #28236, generic methods should not cause warnings in Dart 1

Instantiate universal functions in subtype tests & tear-offs. Also updates the
status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/816592a9417cd9e02be4fd8683961caed4e210b7
==========

[Jennifer Messerly, 2017-01-09 20:46:28]

Committed patchset #2 (id:20001) manually as
816592a9417cd9e02be4fd8683961caed4e210b7 (presubmit successful).

[Paul Berry, 2017-01-10 13:41:21]

On 2017/01/09 20:46:28, Jennifer Messerly wrote:
> Committed patchset #2 (id:20001) manually as
> 816592a9417cd9e02be4fd8683961caed4e210b7 (presubmit successful).

This CL appears to have caused some analysis server unit tests to fail (see
https://build.chromium.org/p/client.dart/builders/analyzer-mac10.11-release-b...).
 Jen, would you mind having a look?

[Jennifer Messerly, 2017-01-10 18:40:46]

On 2017/01/10 13:41:21, Paul Berry wrote:
> On 2017/01/09 20:46:28, Jennifer Messerly wrote:
> > Committed patchset #2 (id:20001) manually as
> > 816592a9417cd9e02be4fd8683961caed4e210b7 (presubmit successful).
> 
> This CL appears to have caused some analysis server unit tests to fail (see
>
https://build.chromium.org/p/client.dart/builders/analyzer-mac10.11-release-b...).
>  Jen, would you mind having a look?

Found it. Fix on the way! Will send to you in a few mins once I get full local
test results.

[Jennifer Messerly, 2017-01-10 19:02:00]

fix is in https://codereview.chromium.org/2622953002/