Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2621423006: [turbofan] Add support for (deferred) instance migration. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for (deferred) instance migration. Fix a deoptimization loop in TurboFan, where we'd constantly fail the same map check due to not trying instance migration, when there are migration targets in the map check list. This deoptimization loop showed up on the React test in Speedometer. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2621423006 Cr-Commit-Position: refs/heads/master@{#42323} Committed: https://chromium.googlesource.com/v8/v8/+/1ff4a8178e48becd54441a9a04ccea79e3074ed3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -32 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 chunk +68 lines, -14 lines 2 comments Download
M src/compiler/js-global-object-specialization.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +14 lines, -7 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +16 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 3 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-13 10:53:11 UTC) #1
Jarin
lgtm https://codereview.chromium.org/2621423006/diff/1/src/compiler/effect-control-linearizer.cc File src/compiler/effect-control-linearizer.cc (right): https://codereview.chromium.org/2621423006/diff/1/src/compiler/effect-control-linearizer.cc#newcode1076 src/compiler/effect-control-linearizer.cc:1076: __ GotoUnless(check, &migrate); __ Branch(check, &done, &migrate);
3 years, 11 months ago (2017-01-13 12:05:38 UTC) #6
Benedikt Meurer
https://codereview.chromium.org/2621423006/diff/1/src/compiler/effect-control-linearizer.cc File src/compiler/effect-control-linearizer.cc (right): https://codereview.chromium.org/2621423006/diff/1/src/compiler/effect-control-linearizer.cc#newcode1076 src/compiler/effect-control-linearizer.cc:1076: __ GotoUnless(check, &migrate); Doesn't work with the current template ...
3 years, 11 months ago (2017-01-13 12:08:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621423006/1
3 years, 11 months ago (2017-01-13 12:08:19 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 12:09:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1ff4a8178e48becd54441a9a04ccea79e30...

Powered by Google App Engine
This is Rietveld 408576698