Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2621423004: Revert pub to script snapshots in the GN build. Fixes #28346. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert pub to script snapshots in the GN build. Fixes #28346. App snapshots do not yet support spawnUri (issue #28368). R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/5062baffb674d2a27077019cd5a8b875d17ae4d3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M utils/application_snapshot.gni View 1 chunk +45 lines, -0 lines 2 comments Download
M utils/pub/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rmacnak
3 years, 11 months ago (2017-01-12 20:34:40 UTC) #2
siva
lgtm
3 years, 11 months ago (2017-01-12 21:06:48 UTC) #3
rmacnak
Committed patchset #1 (id:1) manually as 5062baffb674d2a27077019cd5a8b875d17ae4d3 (presubmit successful).
3 years, 11 months ago (2017-01-12 21:07:35 UTC) #5
zra
https://codereview.chromium.org/2621423004/diff/1/utils/application_snapshot.gni File utils/application_snapshot.gni (right): https://codereview.chromium.org/2621423004/diff/1/utils/application_snapshot.gni#newcode56 utils/application_snapshot.gni:56: assert(defined(invoker.training_args), "Must specify 'training_args'") Why does a script snapshot ...
3 years, 11 months ago (2017-01-12 21:12:42 UTC) #7
rmacnak
3 years, 11 months ago (2017-01-13 18:47:42 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/2621423004/diff/1/utils/application_snapshot.gni
File utils/application_snapshot.gni (right):

https://codereview.chromium.org/2621423004/diff/1/utils/application_snapshot....
utils/application_snapshot.gni:56: assert(defined(invoker.training_args), "Must
specify 'training_args'")
On 2017/01/12 21:12:41, zra wrote:
> Why does a script snapshot need training args?

It doesn't. This was a quick fix and removed in
https://codereview.chromium.org/2628283002.

Powered by Google App Engine
This is Rietveld 408576698