Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2628283002: Support spawnUri in app snapshots. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Total comments: 5

Patch Set 3 : const pointer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -93 lines) Patch
M runtime/bin/main.cc View 1 2 12 chunks +56 lines, -16 lines 0 comments Download
M runtime/bin/snapshot_empty.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/snapshot_in.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/isolate.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/benchmark_test.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/isolate_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/metrics_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/unit_test.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/zone_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M utils/application_snapshot.gni View 1 1 chunk +0 lines, -45 lines 0 comments Download
M utils/pub/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
3 years, 11 months ago (2017-01-13 01:05:49 UTC) #2
siva
lgtm https://codereview.chromium.org/2628283002/diff/20001/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/2628283002/diff/20001/runtime/bin/main.cc#newcode43 runtime/bin/main.cc:43: extern const uint8_t* core_isolate_snapshot_buffer; should we declare this ...
3 years, 11 months ago (2017-01-13 18:11:14 UTC) #3
rmacnak
https://codereview.chromium.org/2628283002/diff/20001/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/2628283002/diff/20001/runtime/bin/main.cc#newcode43 runtime/bin/main.cc:43: extern const uint8_t* core_isolate_snapshot_buffer; On 2017/01/13 18:11:13, siva wrote: ...
3 years, 11 months ago (2017-01-13 18:32:45 UTC) #4
rmacnak
3 years, 11 months ago (2017-01-13 18:37:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
593d4504b0e7b9a8c2b920da1d341c8e55ce58ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698