Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2621413007: Revert of Re-enable fetching component policies for login screen apps (Closed)

Created:
3 years, 11 months ago by Thiemo Nagel
Modified:
3 years, 11 months ago
Reviewers:
emaxx
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable fetching component policies for login screen apps (patchset #3 id:40001 of https://codereview.chromium.org/2603463003/ ) Reason for revert: I'm very sorry I have to revert this since it's breaking device policy updates. https://bugs.chromium.org/p/chromium/issues/detail?id=679956#c7 Original issue's description: > Re-enable fetching component policies for login screen apps > > This CL relands enabling fetching of policies for Chrome OS login screen > apps. > > The originally landed code was temporarily disabled due to DMServer > responding with errors when an unknown policy type was requested. Now > this can be enabled back, after the DMServer got fixed to at least > ignore the new policy type (until it starts to actually provide policies > with this type). > > BUG=644304, 666720 > TEST=re-enabled browser tests; > manual test: sign into an enrolled device, go to chrome://policy > and check that the device policies were fetched successfully > > Committed: https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3 > Cr-Commit-Position: refs/heads/master@{#441015} TBR=emaxx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=644304, 666720 Review-Url: https://codereview.chromium.org/2621413007 Cr-Commit-Position: refs/heads/master@{#443328} Committed: https://chromium.googlesource.com/chromium/src/+/3cce5ba611580090dbbd55686e0372a2a4955bbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc View 7 chunks +25 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Thiemo Nagel
Created Revert of Re-enable fetching component policies for login screen apps
3 years, 11 months ago (2017-01-12 18:51:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621413007/1
3 years, 11 months ago (2017-01-12 18:52:02 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:47:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3cce5ba611580090dbbd55686e03...

Powered by Google App Engine
This is Rietveld 408576698