Descriptioncc: Don't create SyncedPropety instances on the main thread.
SyncedProperty is used as a synchronization primitive to track state on
the impl thread, necessary to resolve conflicts for concurrent main-impl
mutations. As such it should only exist on the impl thread.
Currently, the ScrollTree creates these on the main thread while they
only store the current main thread value. This is unnecessary complexity
that can be avoided. This change makes ScrollTree store just the offset
on the main thread, and a SyncedProperty for the offset on the impl thread.
BUG=662619
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2621403003
Cr-Commit-Position: refs/heads/master@{#443325}
Committed: https://chromium.googlesource.com/chromium/src/+/5889b84078b874e7682a4634b1fce6eedcac67fb
Patch Set 1 #
Total comments: 8
Patch Set 2 : Addressed comments. #
Total comments: 3
Patch Set 3 : Comment update #Patch Set 4 : win test #
Messages
Total messages: 20 (11 generated)
|