Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2621393003: Remove ScrollbarTestSuite from platform/scroll (Closed)

Created:
3 years, 11 months ago by Takashi Toyoshima
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScrollbarTestSuite from platform/scroll ScrollbarTestSuite registers Platform::current()->compositorSupport() to TestingPlatformSupportWithMockScheduler, but TestingPlatformSupportWithMockScheduler does the same thing internally. So we can just remove ScrollbarTestSuite without any behavior change. BUG=n/a TEST=blink_platform_unittests Review-Url: https://codereview.chromium.org/2621393003 Cr-Commit-Position: refs/heads/master@{#443509} Committed: https://chromium.googlesource.com/chromium/src/+/883980129c6938e83dca43abb9f1693d2ed77274

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -46 lines) Patch
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 6 chunks +13 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h View 2 chunks +0 lines, -13 lines 1 comment Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAuraTest.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
Takashi Toyoshima
PTAL, this is the follow-up CL we discussed. https://codereview.chromium.org/2621393003/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h File third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h (left): https://codereview.chromium.org/2621393003/diff/1/third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h#oldcode90 third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h:90: m_config.compositorSupport ...
3 years, 11 months ago (2017-01-12 13:19:47 UTC) #5
haraken
LGTM
3 years, 11 months ago (2017-01-12 15:57:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621393003/1
3 years, 11 months ago (2017-01-13 06:28:31 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 06:33:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/883980129c6938e83dca43abb9f1...

Powered by Google App Engine
This is Rietveld 408576698