[Sync] Renamed OnMetadataLoaded to ModelReadyToSync.

[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes and comment updates.

BUG=680614
TBR=olivierrobin

Review-Url: https://codereview.chromium.org/2621373004
Cr-Commit-Position: refs/heads/master@{#444759}
Committed: https://chromium.googlesource.com/chromium/src/+/a7aece49f006dc71eb73e924e65f6a44d6a094d9

[skym, 2017-01-12 19:10:14]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 19:10:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-01-12 19:11:40]

Description was changed from

==========
Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyForSyncing.

BUG=680614
==========

to

==========
Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyForSyncing.

Also contains minor lint fixes.

BUG=680614
==========

[skym, 2017-01-12 19:11:47]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org, olivierrobin@chromium.org

[skym, 2017-01-12 19:11:47]

PTAL. maxbogue@ for sync code, olvierrobin@ for reading list code.

[skym, 2017-01-12 19:17:15]

Description was changed from

==========
Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyForSyncing.

Also contains minor lint fixes.

BUG=680614
==========

to

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to
ModelReadyForSyncing.

Also contains minor lint fixes.

BUG=680614
==========

[skym, 2017-01-12 19:21:19]

Description was changed from

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to
ModelReadyForSyncing.

Also contains minor lint fixes.

BUG=680614
==========

to

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes.

BUG=680614
==========

[maxbogue, 2017-01-12 19:27:52]

https://codereview.chromium.org/2621373004/diff/1/components/sync/model/model...
File components/sync/model/model_type_change_processor.h (right):

https://codereview.chromium.org/2621373004/diff/1/components/sync/model/model...
components/sync/model/model_type_change_processor.h:51: // Accept the initial
sync metadata loaded by the bridge. This must be called
Clarify here that this must be called exactly once ASAP when the model has
access to the metadata? This comment doesn't seem to fit the name anymore.

https://codereview.chromium.org/2621373004/diff/1/components/sync/model/model...
components/sync/model/model_type_change_processor.h:54: virtual void
ModelReadyForSyncing(std::unique_ptr<MetadataBatch> batch) = 0;
Recording here for posterity that I'm a jerk and asked you to change this to
ModelReadyToSync after I was the one that suggested ModelReadyForSyncing.

https://codereview.chromium.org/2621373004/diff/1/components/sync/model/model...
File components/sync/model/model_type_sync_bridge_unittest.cc (right):

https://codereview.chromium.org/2621373004/diff/1/components/sync/model/model...
components/sync/model/model_type_sync_bridge_unittest.cc:30:
on_metadata_loaded_batch_ = std::move(batch);
Rename var; metadata_batch_ maybe?

[skym, 2017-01-12 20:02:49]

Description was changed from

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes.

BUG=680614
==========

to

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes and comment updates.

BUG=680614
==========

[skym, 2017-01-12 20:14:17]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-01-12 20:14:37]

Updated for Max's comments.

[commit-bot: I haz the power, 2017-01-12 20:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2017-01-12 20:35:05]

lgtm

[commit-bot: I haz the power, 2017-01-12 21:07:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 21:07:33]

Dry run: This issue passed the CQ dry run.

[skym, 2017-01-18 21:27:52]

Description was changed from

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes and comment updates.

BUG=680614
==========

to

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes and comment updates.

BUG=680614
TBR=olivierrobin
==========

[skym, 2017-01-18 21:28:17]

TBR'ing olivierrobin as this is just a method rename.

[skym, 2017-01-18 21:28:38]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Olivier, 2017-01-18 21:30:14]

ios Reading List LGTM

[commit-bot: I haz the power, 2017-01-18 21:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:38:46]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[skym, 2017-01-19 15:38:48]

The CQ bit was checked by skym@chromium.org

[skym, 2017-01-19 15:38:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org, olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2621373004/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-19 15:39:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 16:25:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484840328038270,
"parent_rev": "cdd3e14ede2ee3f82d23a38f06d94ec60060c351", "commit_rev":
"a7aece49f006dc71eb73e924e65f6a44d6a094d9"}

[commit-bot: I haz the power, 2017-01-19 16:26:06]

Description was changed from

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes and comment updates.

BUG=680614
TBR=olivierrobin
==========

to

==========
[Sync] Renamed ModelTypeChangeProcessor::OnMetadataLoaded to ModelReadyToSync.

Also contains minor lint fixes and comment updates.

BUG=680614
TBR=olivierrobin

Review-Url: https://codereview.chromium.org/2621373004
Cr-Commit-Position: refs/heads/master@{#444759}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7aece49f006dc71eb73e924e65f...
==========

[commit-bot: I haz the power, 2017-01-19 16:26:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a7aece49f006dc71eb73e924e65f...