Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2621373003: cleanup: Remove stylus check within OnMouseEvent for TabletPowerButtonController (Closed)

Created:
3 years, 11 months ago by Qiang(Joe) Xu
Modified:
3 years, 11 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cleanup: Remove stylus check within OnMouseEvent for TabletPowerButtonController Changes: stylus 'touch' event is no longer mouse event based on the cl: https://codereview.chromium.org/2507503002/, which leads to this cleanup change. BUG=633304 TEST=tested that stylus touch event will not wake the device (both in laptop mode and tablet mode) on kevin. Review-Url: https://codereview.chromium.org/2621373003 Cr-Commit-Position: refs/heads/master@{#443154} Committed: https://chromium.googlesource.com/chromium/src/+/80fccc61857e261e52bed6c44a6d4f0ec97aff72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M ash/system/chromeos/power/tablet_power_button_controller.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ash/system/chromeos/power/tablet_power_button_controller_unittest.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Qiang(Joe) Xu
Hi Daniel, ptal, thanks!
3 years, 11 months ago (2017-01-12 00:32:58 UTC) #4
Daniel Erat
lgtm
3 years, 11 months ago (2017-01-12 01:34:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621373003/1
3 years, 11 months ago (2017-01-12 01:57:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/263259)
3 years, 11 months ago (2017-01-12 02:09:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621373003/1
3 years, 11 months ago (2017-01-12 03:58:00 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 04:49:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80fccc61857e261e52bed6c44a6d...

Powered by Google App Engine
This is Rietveld 408576698