Remove Kasko!

Remove Kasko!

Kasko isn't needed (or used) anymore and so there's no reason to keep
this code anymore.

BUG=680162
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2621363002
Cr-Commit-Position: refs/heads/master@{#447677}
Committed: https://chromium.googlesource.com/chromium/src/+/f39bc2fdcbd42e8dc12ff14e609b05135c04f467

[Sébastien Marchand, 2017-01-11 17:16:04]

Description was changed from

==========
Remove Kasko!
==========

to

==========
Remove Kasko!
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sébastien Marchand, 2017-01-11 17:17:40]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 17:18:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:14:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:14:28]

Dry run: This issue passed the CQ dry run.

[Sébastien Marchand, 2017-01-12 14:44:38]

sebmarchand@chromium.org changed reviewers:
+ chrisha@chromium.org, scottmg@chromium.org

[Sébastien Marchand, 2017-01-12 14:44:39]

I should probably try to split this into smaller CL, or find a / owner to
approve it, wdyt?

[Sébastien Marchand, 2017-01-12 14:44:57]

Description was changed from

==========
Remove Kasko!
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove Kasko!

BUG=680162
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[scottmg, 2017-01-12 16:23:47]

I don't think there's any need to split it up, you can get a stamp from a top
level owner for something like this.

Are we losing any important integration testing for chrome/syzyasan that
happened in the kasko integration tests here? (Chris?)

https://codereview.chromium.org/2621363002/diff/1/net/http/transport_security...
File net/http/transport_security_state_static.json (left):

https://codereview.chromium.org/2621363002/diff/1/net/http/transport_security...
net/http/transport_security_state_static.json:3277: -    { "name": "kasko.io",
"include_subdomains": true, "mode": "force-https" },
This seems a bit too aggressive. :)

[Sébastien Marchand, 2017-01-12 16:59:01]

AFAIK we don't use the integration tests, we wanted to but we never finished the
integration with our SyzyAsan builder (partly because we were working on
removing Kasko in parallel, so it was weird to work on adding some integration
tests for something that we're trying to remove).

https://codereview.chromium.org/2621363002/diff/1/net/http/transport_security...
File net/http/transport_security_state_static.json (left):

https://codereview.chromium.org/2621363002/diff/1/net/http/transport_security...
net/http/transport_security_state_static.json:3277: -    { "name": "kasko.io",
"include_subdomains": true, "mode": "force-https" },
On 2017/01/12 16:23:47, scottmg wrote:
> This seems a bit too aggressive. :)

Haha! Oops :), to be honest the title of this CL talk about removing Kasko, I'm
not specific about which one.

[scottmg, 2017-01-12 17:25:04]

lgtm

[Sébastien Marchand, 2017-01-12 18:07:40]

Thanks, waiting for Chris' stamp and I'll add a src/ owner (Brett or Jam)

[Sébastien Marchand, 2017-01-12 18:09:24]

sebmarchand@chromium.org changed reviewers:
+ syzygy-team@chromium.org

[Sébastien Marchand, 2017-01-12 18:09:25]

+syzygy-team@ fyi.

[Sébastien Marchand, 2017-01-12 18:17:32]

sebmarchand@chromium.org changed reviewers:
+ manzagop@chromium.org

[Sébastien Marchand, 2017-01-12 18:17:32]

I've also removed testing/scripts/syzyasan_integration_tests.py (it's depending
on Kasko), and removed the Kasko entry from tools/licenses.py.

Note that there's still a few references to Kasko in the code:


[bye_kasko]C:\src\chrome\src>git grep -i kasko
chrome/chrome_watcher/chrome_watcher_main.cc:  // Signal our client now that the
Kasko reporter is initialized and we have
chrome/chrome_watcher/chrome_watcher_main_api.h:// enabled, a Kasko reporter
process is also instantiated, using
components/crash/content/app/crashpad.h:// that it may be reused by
GetCrashKeysForKasko.
components/policy/resources/policy_templates_fi.xtb:      Jos asetus ei ole
käytössä ja lähtevät UDP-yhteydet menevät palomuurin kautta, tämä kone hyväksyy
vain paikallisessa verkossa olevien asiakaskoneiden yhteydet.
net/http/transport_security_state_static.json:    { "name": "kasko.io",
"include_subdomains": true, "mode": "force-https" },
tools/metrics/histograms/histograms.xml:    Counts crash reports that the Kasko
crash reporter fails to upload and hands
tools/metrics/histograms/histograms.xml:    off to Chrome. Kasko stores the
failed reports in a location specified by

I'm not sure of what to do with the ones in chrome_watcher and in
histograms.xml, +manzagop@ for that.

There's also one in crashpad.h, I leave this to Scott.

[scottmg, 2017-01-12 18:42:28]

On 2017/01/12 18:17:32, Sébastien Marchand wrote:
> I've also removed testing/scripts/syzyasan_integration_tests.py (it's
depending
> on Kasko), and removed the Kasko entry from tools/licenses.py.
> 
> Note that there's still a few references to Kasko in the code:
> 
> 
> [bye_kasko]C:\src\chrome\src>git grep -i kasko
> chrome/chrome_watcher/chrome_watcher_main.cc:  // Signal our client now that
the
> Kasko reporter is initialized and we have
> chrome/chrome_watcher/chrome_watcher_main_api.h:// enabled, a Kasko reporter
> process is also instantiated, using
> components/crash/content/app/crashpad.h:// that it may be reused by
> GetCrashKeysForKasko.
> components/policy/resources/policy_templates_fi.xtb:      Jos asetus ei ole
> käytössä ja lähtevät UDP-yhteydet menevät palomuurin kautta, tämä kone
hyväksyy
> vain paikallisessa verkossa olevien asiakaskoneiden yhteydet.
> net/http/transport_security_state_static.json:    { "name": "kasko.io",
> "include_subdomains": true, "mode": "force-https" },
> tools/metrics/histograms/histograms.xml:    Counts crash reports that the
Kasko
> crash reporter fails to upload and hands
> tools/metrics/histograms/histograms.xml:    off to Chrome. Kasko stores the
> failed reports in a location specified by
> 
> I'm not sure of what to do with the ones in chrome_watcher and in
> histograms.xml, +manzagop@ for that.
> 
> There's also one in crashpad.h, I leave this to Scott.

We can flatten that function back into its one callsite I guess, but better to
do that in another CL to keep this one focused on Just Deleeeeeeting!

[Sébastien Marchand, 2017-01-12 18:47:02]

Yeah, I've to admit that I'm a little bit sad about the '+1 line' in the CL's
Stats column...

[manzagop (departed), 2017-01-12 18:56:50]

For chrome_watcher_main.cc and chrome_watcher_main_api.h you can simply remove
the kasko mention from those comments. The mechanism is still the same, there's
simply no kasko.

For histograms.xml, I think you're supposed to leave the metric them but add an
<obsolete> tag.

[Sébastien Marchand, 2017-01-12 19:32:12]

Removed the Kasko references from chrome_watcher. The last reference to Kasko is
in crashpad.h!

[chrisha, 2017-01-12 19:59:06]

Yes, the "kasko/integration_test.py" is making sure that the entire system
works, end-to-end. Once upon a time I had modified that to also work with
Crashpad and I have zero recollection of the current status.

Let me dig around to see where this is at, and if that test is even still
running.

[Sébastien Marchand, 2017-01-19 19:04:07]

ping?

[Sébastien Marchand, 2017-01-24 16:12:47]

gentle ping.

[manzagop (departed), 2017-01-24 16:14:36]

lgtm for what we discussed.

[chrisha, 2017-01-26 16:04:51]

Awesome, lgtm!

As a follow-up, we should file a bug to investigate if Kasko files/directories
are left behind in any significant numbers, and launch a cleanup task at some
point after Chrome startup.

[Sébastien Marchand, 2017-02-01 19:01:18]

Thanks, filed crbug.com/687661.

Fire in the hole!

[Sébastien Marchand, 2017-02-01 19:01:25]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2017-02-01 19:01:26]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2621363002/#ps60001
(title: "Update histograms.xml and chrome_watcher.")

[commit-bot: I haz the power, 2017-02-01 19:02:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 19:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 19:06:03]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sébastien Marchand, 2017-02-01 19:24:01]

I need to rebase this and I still need a / owner stamp :)

[Sébastien Marchand, 2017-02-01 19:44:00]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 19:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 20:01:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 20:01:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sébastien Marchand, 2017-02-01 20:07:43]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 20:08:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2017-02-01 20:53:20]

Description was changed from

==========
Remove Kasko!

BUG=680162
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove Kasko!

Kasko isn't needed (or used) anymore and so there's no reason to keep
this code anymore.

BUG=680162
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sébastien Marchand, 2017-02-01 20:54:05]

sebmarchand@chromium.org changed reviewers:
+ jam@chromium.org

[Sébastien Marchand, 2017-02-01 20:54:06]

+jam@ for / owner approval, PTAL.

[commit-bot: I haz the power, 2017-02-01 21:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:13:34]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[jam, 2017-02-01 23:10:02]

lgtm

[Sébastien Marchand, 2017-02-02 00:38:22]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2017-02-02 00:38:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
manzagop@chromium.org, chrisha@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2621363002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-02 00:38:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 00:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:48:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sébastien Marchand, 2017-02-02 00:54:57]

sebmarchand@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Sébastien Marchand, 2017-02-02 00:54:58]

+asvitkine@ for histograms approval

[Alexei Svitkine (slow), 2017-02-02 00:57:18]

histograms.xml lgtm

[Sébastien Marchand, 2017-02-02 00:57:37]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:58:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 01:42:45]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485997057948650,
"parent_rev": "7df3c119b83d5b30eb201c7310141e4f87a326d1", "commit_rev":
"f39bc2fdcbd42e8dc12ff14e609b05135c04f467"}

[commit-bot: I haz the power, 2017-02-02 01:46:46]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485997057948650,
"parent_rev": "7df3c119b83d5b30eb201c7310141e4f87a326d1", "commit_rev":
"f39bc2fdcbd42e8dc12ff14e609b05135c04f467"}

[commit-bot: I haz the power, 2017-02-02 01:46:53]

Description was changed from

==========
Remove Kasko!

Kasko isn't needed (or used) anymore and so there's no reason to keep
this code anymore.

BUG=680162
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove Kasko!

Kasko isn't needed (or used) anymore and so there's no reason to keep
this code anymore.

BUG=680162
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2621363002
Cr-Commit-Position: refs/heads/master@{#447677}
Committed:
https://chromium.googlesource.com/chromium/src/+/f39bc2fdcbd42e8dc12ff14e609b...
==========

[commit-bot: I haz the power, 2017-02-02 01:46:55]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f39bc2fdcbd42e8dc12ff14e609b...