Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2621303003: [TurboFan] Fix JSNativeContextSpecialization::InferReceiverMap (Closed)

Created:
3 years, 11 months ago by Toon Verwaest
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan] Fix JSNativeContextSpecialization::InferReceiverMap Before the fix it checked whether the initial map of the base constructor pointed back to the new target. That's only true if initial_map->new_target_is_base() (new.target == target). Now it properly checks that the initial map of the original constructor (new.target) was created in combination with target by checking back that new.target->initial_map()->constructor() == target. BUG= Review-Url: https://codereview.chromium.org/2621303003 Cr-Commit-Position: refs/heads/master@{#42263} Committed: https://chromium.googlesource.com/v8/v8/+/2bca05685f6d7302124a54a2b1028cbad8f2c7b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Toon Verwaest
ptal
3 years, 11 months ago (2017-01-12 10:53:36 UTC) #2
Benedikt Meurer
Nice, thanks. LGTM.
3 years, 11 months ago (2017-01-12 10:54:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621303003/1
3 years, 11 months ago (2017-01-12 10:55:31 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 11:23:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2bca05685f6d7302124a54a2b1028cbad8f...

Powered by Google App Engine
This is Rietveld 408576698