ARC is not allowed for incognito profile.

ARC is not allowed for incognito profile.

IsPrimaryProfile can return true for the incognito profile
which is corresponding to the primary profile.
Exclude it from the ARC supporting.

BUG=676725
TEST=Manually made sure EventRouter does not registered to
     ArcServiceManager, even when an incognito window is opened.

Review-Url: https://codereview.chromium.org/2621293002
Cr-Commit-Position: refs/heads/master@{#442912}
Committed: https://chromium.googlesource.com/chromium/src/+/ca09e631a7cd5999dfd434371aca0d8eec715cf2

[hidehiko, 2017-01-11 11:25:17]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 11:25:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 11:56:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 11:56:47]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-01-11 14:22:03]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2017-01-11 14:22:04]

PTAL: Luis.
FYI: yusukes@, nya@, fukino@ and oka@.

[hidehiko, 2017-01-11 14:29:42]

https://codereview.chromium.org/2621293002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.cc (right):

https://codereview.chromium.org/2621293002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.cc:166: // IsPrimaryProfile can
return true for an incognito profile corresponding
Note: I'm not very sure if this is intentional behavior or not, but
IsPrimaryProfile() is used in non-ARC code as well, so considering the
side-effect, I'd like to fix this in ARC code for now.

I think, maybe we should talk to Profile experts and other clients
(wallpaper/vpn) team later?

[Luis Héctor Chávez, 2017-01-11 15:45:50]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2017-01-11 15:45:51]

lgtm

[commit-bot: I haz the power, 2017-01-11 15:46:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:51:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484149550561950, "parent_rev":
"95ae77193e1dbd5a7e6048095d0100597e626e83", "commit_rev":
"ca09e631a7cd5999dfd434371aca0d8eec715cf2"}

[commit-bot: I haz the power, 2017-01-11 15:51:44]

Description was changed from

==========
ARC is not allowed for incognito profile.

IsPrimaryProfile can return true for the incognito profile
which is corresponding to the primary profile.
Exclude it from the ARC supporting.

BUG=676725
TEST=Manually made sure EventRouter does not registered to
     ArcServiceManager, even when an incognito window is opened.
==========

to

==========
ARC is not allowed for incognito profile.

IsPrimaryProfile can return true for the incognito profile
which is corresponding to the primary profile.
Exclude it from the ARC supporting.

BUG=676725
TEST=Manually made sure EventRouter does not registered to
     ArcServiceManager, even when an incognito window is opened.

Review-Url: https://codereview.chromium.org/2621293002
Cr-Commit-Position: refs/heads/master@{#442912}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca09e631a7cd5999dfd434371aca...
==========

[commit-bot: I haz the power, 2017-01-11 15:51:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca09e631a7cd5999dfd434371aca...