Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: remoting/host/win/BUILD.gn

Issue 2621223003: Fix building ASAN instrumented executables with custom entrypoints (Closed)
Patch Set: nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/win/BUILD.gn
diff --git a/remoting/host/win/BUILD.gn b/remoting/host/win/BUILD.gn
index f6ddd335c88031124f7013d95a26fd75bf6cdfc8..e7adc69d98afd44ae1b2200c755f1c13bd681423 100644
--- a/remoting/host/win/BUILD.gn
+++ b/remoting/host/win/BUILD.gn
@@ -276,10 +276,9 @@ executable("remoting_console") {
"entry_point.cc",
]
- ldflags = [
- "/ENTRY:HostEntryPoint",
- # "/NODEFAULTLIB",
grt (UTC plus 2) 2017/01/16 15:41:17 maybe preserve a comment about this? was the origi
etienneb 2017/01/16 16:58:37 Done.
- ]
+ if (!is_asan) {
+ ldflags = [ "/ENTRY:HostEntryPoint" ]
+ }
}
executable("remoting_me2me_host") {
@@ -304,7 +303,9 @@ executable("remoting_me2me_host") {
output_name = "remoting_host"
- ldflags = [ "/ENTRY:HostEntryPoint" ]
+ if (!is_asan) {
+ ldflags = [ "/ENTRY:HostEntryPoint" ]
+ }
}
shared_library("remoting_core") {
@@ -440,10 +441,9 @@ executable("remoting_desktop") {
"entry_point.cc",
]
- ldflags = [
- "/ENTRY:HostEntryPoint",
- # "/NODEFAULTLIB",
grt (UTC plus 2) 2017/01/16 15:41:17 same comment about comment
etienneb 2017/01/16 16:58:37 Done.
- ]
+ if (!is_asan) {
+ ldflags = [ "/ENTRY:HostEntryPoint" ]
+ }
}
executable("remoting_native_messaging_host") {

Powered by Google App Engine
This is Rietveld 408576698