Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2621203004: Correctly hide the content suggestions menu item by default. (Closed)

Created:
3 years, 11 months ago by Bernhard Bauer
Modified:
3 years, 11 months ago
Reviewers:
dgn
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly hide the content suggestions menu item by default. Setting android:visible="false" only seems to work on groups, not individual items. Review-Url: https://codereview.chromium.org/2621203004 Cr-Commit-Position: refs/heads/master@{#442950} Committed: https://chromium.googlesource.com/chromium/src/+/125acff999977b79a1f8c9f69257d1126973c5e5

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/android/java/res/menu/main_menu.xml View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Bernhard Bauer
Please review.
3 years, 11 months ago (2017-01-11 17:15:04 UTC) #6
dgn
lgtm
3 years, 11 months ago (2017-01-11 17:22:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621203004/20001
3 years, 11 months ago (2017-01-11 17:24:18 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 17:51:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/125acff999977b79a1f8c9f69257...

Powered by Google App Engine
This is Rietveld 408576698