Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2621193004: Allow navigations to frames that aren't being unloaded in the unload handler. (Closed)

Created:
3 years, 11 months ago by lfg
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Allow navigations to frames that aren't being unloaded in the unload handler. This change lets the page navigate frames that aren't being unloaded in the unload handler. For example, a popup may want to navigate its opener while it's being closed. FrameLoader now also correctly checks if the |targetFrame| can be navigated, instead of checking if |m_frame| can be navigated. BUG=660496 Review-Url: https://codereview.chromium.org/2487403002 Cr-Commit-Position: refs/heads/master@{#442353} (cherry picked from commit 2267cfcce06c92602376754343e5f45effeee1f1) TBR=dcheng@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2621193004 Cr-Commit-Position: refs/branch-heads/2924@{#736} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/99a040bf679e8d63f3836a7dfddbab77b95c5f22

Patch Set 1 #

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621193004/1
3 years, 11 months ago (2017-01-12 00:46:39 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:52:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99a040bf679e8d63f3836a7dfddb...

Powered by Google App Engine
This is Rietveld 408576698