Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2621193003: Don't condition on the branding when choosing LTO and CFI. (Closed)

Created:
3 years, 11 months ago by krasin1
Modified:
3 years, 11 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't condition on the branding when choosing LTO and CFI. BUG=678915 Review-Url: https://codereview.chromium.org/2621193003 Cr-Commit-Position: refs/heads/master@{#442969} Committed: https://chromium.googlesource.com/chromium/src/+/eed4ea8fb01d92a623f3d912d3ea904e7740e13f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M build/config/sanitizers/sanitizers.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
krasin1
3 years, 11 months ago (2017-01-11 17:00:41 UTC) #4
hans
lgtm (i think you need nico for owners' in build/ though)
3 years, 11 months ago (2017-01-11 17:07:03 UTC) #6
krasin1
On 2017/01/11 17:07:03, hans wrote: > lgtm > > (i think you need nico for ...
3 years, 11 months ago (2017-01-11 17:09:50 UTC) #7
Nico
lgtm
3 years, 11 months ago (2017-01-11 17:44:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621193003/1
3 years, 11 months ago (2017-01-11 18:48:34 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 18:53:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eed4ea8fb01d92a623f3d912d3ea...

Powered by Google App Engine
This is Rietveld 408576698