Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2621193002: Remove unused FirstFileHandlerForEntry() (Closed)

Created:
3 years, 11 months ago by michaelpg
Modified:
3 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused FirstFileHandlerForEntry() Precursor to some possible refactoring to extract the file_handlers API from //chrome to //extensions. BUG=679870 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2621193002 Cr-Commit-Position: refs/heads/master@{#443309} Committed: https://chromium.googlesource.com/chromium/src/+/2d3d04ad2ce2dc65573d4b6399d3a9b88ee9e58f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M apps/launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
michaelpg
3 years, 11 months ago (2017-01-10 23:15:38 UTC) #5
benwells
lgtm
3 years, 11 months ago (2017-01-12 06:08:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621193002/1
3 years, 11 months ago (2017-01-12 16:53:11 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 18:56:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d3d04ad2ce2dc65573d4b6399d3...

Powered by Google App Engine
This is Rietveld 408576698