Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2621183002: [TO 56] Fix race in media Pipeline::GetMediaTime() after seeking. (Closed)

Created:
3 years, 11 months ago by chcunningham
Modified:
3 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[TO 56] Fix race in media Pipeline::GetMediaTime() after seeking. Seeking posts a task from main thread to media thread to seek the renderer. Calling GetMediaTime() should be safe even when the renderer has not yet received the message to performed the seek. This change gaurds against using the renderer's media time while a seek is pending. This prevents polluting |last_media_time_| with bad values from the renderer that doesn't yet know about the seek. BUG=675556 TEST=New unit test && manually verfied bug fix. TBR=sandersd@chromium.org Review-Url: https://codereview.chromium.org/2616703002 Cr-Commit-Position: refs/heads/master@{#441526} (cherry picked from commit 454da202ef172f3ecbfb48c154ff97c8c10011b0) Review-Url: https://codereview.chromium.org/2621183002 . Cr-Commit-Position: refs/branch-heads/2924@{#722} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/f683e0741087dbe0ddf4ed5d878bc72b61246ff8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M media/base/pipeline_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/pipeline_impl.cc View 5 chunks +13 lines, -0 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chcunningham
3 years, 11 months ago (2017-01-10 22:04:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f683e0741087dbe0ddf4ed5d878bc72b61246ff8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698