Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2621173002: Remove --harmony-async-await runtime flag (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com, Michael Hablich, caitp, ofrobots
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-async-await runtime flag It shipped with Chrome 55 stable. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2621173002 Cr-Commit-Position: refs/heads/master@{#42203} Committed: https://chromium.googlesource.com/v8/v8/+/66178c8f53a0b8b39ead5b52d95a7ca27fbdcf81

Patch Set 1 #

Patch Set 2 : Update test ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -3535 lines) Patch
M src/bootstrapper.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 5 chunks +7 lines, -12 lines 0 comments Download
M src/parsing/parser-base.h View 7 chunks +4 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 22 chunks +26 lines, -106 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-basic.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-caught-exception.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-caught-exception-cases.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-caught-exception-cases0.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-caught-exception-cases1.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-caught-exception-cases2.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-caught-exception-cases3.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-abort-at-break.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-continue-at-break.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-in.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-in-and-out.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-in-out-out.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-nested.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-next.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-next-constant.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-debug-step-out.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-function-debug-evaluate.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/async-function-debug-scopes.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/debug-async-break.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/debug-async-break-on-stack.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/es8/debug-async-liveedit.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-basic.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-caught-exception.js View 1 chunk +0 lines, -144 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-caught-exception-cases.js View 1 chunk +0 lines, -215 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-caught-exception-cases0.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-caught-exception-cases1.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-caught-exception-cases2.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-caught-exception-cases3.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-abort-at-break.js View 1 chunk +0 lines, -55 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-continue-at-break.js View 1 chunk +0 lines, -55 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-in.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-in-and-out.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-in-out-out.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-nested.js View 1 chunk +0 lines, -58 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-next.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-next-constant.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/debugger/debug/harmony/async-debug-step-out.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/debugger/debug/harmony/async-function-debug-evaluate.js View 1 chunk +0 lines, -139 lines 0 comments Download
D test/debugger/debug/harmony/async-function-debug-scopes.js View 1 chunk +0 lines, -550 lines 0 comments Download
D test/debugger/debug/harmony/debug-async-break.js View 1 chunk +0 lines, -75 lines 0 comments Download
D test/debugger/debug/harmony/debug-async-break-on-stack.js View 1 chunk +0 lines, -77 lines 0 comments Download
D test/debugger/debug/harmony/debug-async-liveedit.js View 1 chunk +0 lines, -132 lines 0 comments Download
M test/debugger/debugger.status View 1 chunk +5 lines, -5 lines 0 comments Download
M test/debugger/regress/regress-5610.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-arrow-lexical-arguments.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-arrow-lexical-new.target.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-arrow-lexical-super.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-arrow-lexical-this.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-await-basic.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-await-no-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-await-resolve-new.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es8/async-await-species.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es8/async-function-stacktrace.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es8/regress/regress-618603.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es8/regress/regress-624300.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es8/sloppy-no-duplicate-async.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/async-arrow-lexical-arguments.js View 1 chunk +0 lines, -42 lines 0 comments Download
D test/mjsunit/harmony/async-arrow-lexical-new.target.js View 1 chunk +0 lines, -43 lines 0 comments Download
D test/mjsunit/harmony/async-arrow-lexical-super.js View 1 chunk +0 lines, -58 lines 0 comments Download
D test/mjsunit/harmony/async-arrow-lexical-this.js View 1 chunk +0 lines, -48 lines 0 comments Download
D test/mjsunit/harmony/async-await-basic.js View 1 chunk +0 lines, -392 lines 0 comments Download
D test/mjsunit/harmony/async-await-no-constructor.js View 1 chunk +0 lines, -27 lines 0 comments Download
D test/mjsunit/harmony/async-await-resolve-new.js View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/harmony/async-await-species.js View 1 chunk +0 lines, -101 lines 0 comments Download
D test/mjsunit/harmony/async-destructuring.js View 1 chunk +0 lines, -516 lines 0 comments Download
D test/mjsunit/harmony/async-function-stacktrace.js View 1 chunk +0 lines, -178 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-618603.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-624300.js View 1 chunk +0 lines, -13 lines 0 comments Download
D test/mjsunit/harmony/sloppy-no-duplicate-async.js View 1 chunk +0 lines, -30 lines 0 comments Download
M test/mjsunit/regress/regress-5405.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
adamk
3 years, 11 months ago (2017-01-10 21:45:45 UTC) #1
Dan Ehrenberg
lgtm Do we want to keep doing these file renames for tests? What if we ...
3 years, 11 months ago (2017-01-10 23:20:49 UTC) #10
gsathya
On 2017/01/10 23:20:49, Dan Ehrenberg wrote: > lgtm > > Do we want to keep ...
3 years, 11 months ago (2017-01-10 23:22:34 UTC) #11
adamk
On 2017/01/10 23:22:34, gsathya wrote: > On 2017/01/10 23:20:49, Dan Ehrenberg wrote: > > lgtm ...
3 years, 11 months ago (2017-01-10 23:24:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621173002/20001
3 years, 11 months ago (2017-01-10 23:24:48 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 23:27:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/66178c8f53a0b8b39ead5b52d95a7ca27fb...

Powered by Google App Engine
This is Rietveld 408576698