Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2621163003: Update MessageCallback typedef Value name (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update MessageCallback typedef Value name The Local<Value> in the MessageCallback typedef is named "error", but should be "data" - it's referred to as "data" everywhere else, and that seems to be the canonical name for a curried-in value. BUG=None Review-Url: https://codereview.chromium.org/2621163003 Cr-Commit-Position: refs/heads/master@{#42234} Committed: https://chromium.googlesource.com/v8/v8/+/0befccd21b2634b841bcec11c51743c50d169796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Devlin
Jochen, mind taking a look? (This was just bothering me.)
3 years, 11 months ago (2017-01-10 21:31:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-11 09:52:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621163003/1
3 years, 11 months ago (2017-01-11 14:46:50 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 14:48:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0befccd21b2634b841bcec11c51743c50d1...

Powered by Google App Engine
This is Rietveld 408576698