media: Fix a GpuVideoDecoder initialization crash on Android

media: Fix a GpuVideoDecoder initialization crash on Android

Previously OnSurfaceAvailable() would call CompleteInitialization() if
init_cb_ was not null, but init_cb_ isn't reset until later in
NotifyInitializationComplete(). So if OnSurfaceAvailable() was called
more than once before deferred initialization completed, we would
erroneously call CompleteInitialization() more than once.

This CL cleans up the logic for OnSurfaceAvailable() so it's safe to call
at any time, and ensures that CompleteInitialization() only runs once.

BUG=677775
Review-Url: https://codereview.chromium.org/2621153004
Cr-Commit-Position: refs/heads/master@{#443124}
Committed: https://chromium.googlesource.com/chromium/src/+/6cc842d8e43b5e2f71b865f51f0aca22aee0c562

[watk, 2017-01-11 01:57:21]

watk@chromium.org changed reviewers:
+ sandersd@chromium.org

[watk, 2017-01-11 02:02:26]

Description was changed from

==========
media: Fix a GpuVideoDecoder initialization crash on Android

Previously OnSurfaceAvailable() would call CompleteInitialization() if
init_cb_ was not null, but init_cb_ isn't reset until later in
NotifyInitializationComplete(). So if OnSurfaceAvailable() was called
more than once before deferred initialization completed, we would
erroneously call CompleteInitialization() more than once.

This CL cleans up the logic for OnSurfaceAvailable() so it's safe to call
at any time, and ensures that CompleteInitialization() only runs once.

BUG=677775
==========

to

==========
media: Fix a GpuVideoDecoder initialization crash on Android

Previously OnSurfaceAvailable() would call CompleteInitialization() if
init_cb_ was not null, but init_cb_ isn't reset until later in
NotifyInitializationComplete(). So if OnSurfaceAvailable() was called
more than once before deferred initialization completed, we would
erroneously call CompleteInitialization() more than once.

This CL cleans up the logic for OnSurfaceAvailable() so it's safe to call
at any time, and ensures that CompleteInitialization() only runs once.

BUG=677775
==========

[watk, 2017-01-11 02:02:26]

watk@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[watk, 2017-01-11 02:02:26]

watk@chromium.org changed required reviewers:
+ sandersd@chromium.org

[watk, 2017-01-11 02:02:47]

sandersd for main review, dalecurtis as FYI. Thanks.

[sandersd (OOO until July 31), 2017-01-11 21:39:58]

lgtm % nit

https://codereview.chromium.org/2621153004/diff/1/media/filters/gpu_video_dec...
File media/filters/gpu_video_decoder.h (right):

https://codereview.chromium.org/2621153004/diff/1/media/filters/gpu_video_dec...
media/filters/gpu_video_decoder.h:181: // Whether |vda_->Initialize()| has been
called.
This is accurate, but hard to interpret with regards to the async initialize
process. Recommend expanding this text to explain that in more detail.

[watk, 2017-01-11 22:33:29]

Updated comments, thanks!

[watk, 2017-01-11 22:33:33]

The CQ bit was checked by watk@chromium.org

[watk, 2017-01-11 22:33:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2621153004/#ps20001
(title: "improve comments")

[commit-bot: I haz the power, 2017-01-11 22:34:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2017-01-11 23:46:29]

Ah, sorry for my bug. Thanks for fixing! lgtm

[commit-bot: I haz the power, 2017-01-12 00:24:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:24:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[watk, 2017-01-12 00:45:23]

The CQ bit was checked by watk@chromium.org

[watk, 2017-01-12 00:45:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2621153004/#ps40001
(title: "bless windows for initializing this with garbage")

[commit-bot: I haz the power, 2017-01-12 00:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:45:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484181923619830,
"parent_rev": "d13ae82cc7bb39b82b1fc4462f856f54418f8c59", "commit_rev":
"6cc842d8e43b5e2f71b865f51f0aca22aee0c562"}

[commit-bot: I haz the power, 2017-01-12 02:46:23]

Description was changed from

==========
media: Fix a GpuVideoDecoder initialization crash on Android

Previously OnSurfaceAvailable() would call CompleteInitialization() if
init_cb_ was not null, but init_cb_ isn't reset until later in
NotifyInitializationComplete(). So if OnSurfaceAvailable() was called
more than once before deferred initialization completed, we would
erroneously call CompleteInitialization() more than once.

This CL cleans up the logic for OnSurfaceAvailable() so it's safe to call
at any time, and ensures that CompleteInitialization() only runs once.

BUG=677775
==========

to

==========
media: Fix a GpuVideoDecoder initialization crash on Android

Previously OnSurfaceAvailable() would call CompleteInitialization() if
init_cb_ was not null, but init_cb_ isn't reset until later in
NotifyInitializationComplete(). So if OnSurfaceAvailable() was called
more than once before deferred initialization completed, we would
erroneously call CompleteInitialization() more than once.

This CL cleans up the logic for OnSurfaceAvailable() so it's safe to call
at any time, and ensures that CompleteInitialization() only runs once.

BUG=677775

Review-Url: https://codereview.chromium.org/2621153004
Cr-Commit-Position: refs/heads/master@{#443124}
Committed:
https://chromium.googlesource.com/chromium/src/+/6cc842d8e43b5e2f71b865f51f0a...
==========

[commit-bot: I haz the power, 2017-01-12 02:46:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6cc842d8e43b5e2f71b865f51f0a...