Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2621153003:
Create TaskScheduler for all Mojo apps. (Closed)
DescriptionCreate TaskScheduler for all Mojo apps.
Running mustash on device currently crashes on startup. This is because
ui::Service doesn't create a TaskScheduler before Ozone DRM uses it. One
option is to have ui::Service::OnStart() create a TaskScheduler. If
other Mojo applications need a task scheduler they'll have to do the
same. Instead, have MashRunner start a TaskRunner for each process.
This fixes the crash in Ozone DRM and doesn't seem to cause any other
problems.
BUG=679840
Review-Url: https://codereview.chromium.org/2621153003
Cr-Commit-Position: refs/heads/master@{#442956}
Committed: https://chromium.googlesource.com/chromium/src/+/3ae6c6b59c0c9a5609fb220d7c494649ad1e826a
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove include. #Messages
Total messages: 30 (20 generated)
kylechar@chromium.org changed reviewers: + fdoray@chromium.org, sky@chromium.org
+sky for OWNERS +fdoray as FYI I talked to fdoray about the crash and he mentioned the TODO in MashRunner. I don't think that dynamic loading from MashRunner happens anymore, so it's possible to start TaskScheduler in MashRunner::Main for all Mojo apps? If not I could start a TaskScheduler in ui::Service::OnStart() instead.
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sky@chromium.org changed reviewers: + rockot@chromium.org
+rockot LGTM
Description was changed from ========== Create TaskScheduler for all Mojo apps. Running mustash on device current crashes on startup. This is because ui::Service doesn't create a TaskScheduler before Ozone DRM uses it. One option is to have ui::Service::OnStart() create a TaskScheduler. If other Mojo applications need a task scheduler they'll have to do the same. Instead, have MashRunner start a TaskRunner for each process. This fixes the crash in Ozone DRM and doesn't seem to cause any other problems. BUG=679840 ========== to ========== Create TaskScheduler for all Mojo apps. Running mustash on device currently crashes on startup. This is because ui::Service doesn't create a TaskScheduler before Ozone DRM uses it. One option is to have ui::Service::OnStart() create a TaskScheduler. If other Mojo applications need a task scheduler they'll have to do the same. Instead, have MashRunner start a TaskRunner for each process. This fixes the crash in Ozone DRM and doesn't seem to cause any other problems. BUG=679840 ==========
lgtm https://codereview.chromium.org/2621153003/diff/1/chrome/app/mash/mash_runner.cc File chrome/app/mash/mash_runner.cc (right): https://codereview.chromium.org/2621153003/diff/1/chrome/app/mash/mash_runner... chrome/app/mash/mash_runner.cc:45: #include "services/service_manager/standalone/context.h" services/service_manager/standalone/context.h is not needed anymore.
TS lgtm
On 2017/01/11 at 14:45:37, Ken Rockot wrote: > TS lgtm rs* :)
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks! https://codereview.chromium.org/2621153003/diff/1/chrome/app/mash/mash_runner.cc File chrome/app/mash/mash_runner.cc (right): https://codereview.chromium.org/2621153003/diff/1/chrome/app/mash/mash_runner... chrome/app/mash/mash_runner.cc:45: #include "services/service_manager/standalone/context.h" On 2017/01/11 14:29:51, fdoray wrote: > services/service_manager/standalone/context.h is not needed anymore. Done.
The CQ bit was checked by kylechar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org, fdoray@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2621153003/#ps20001 (title: "Remove include.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484152115188620,
"parent_rev": "c197aaf856fea65148a930dd4219937d0749f12d", "commit_rev":
"9ac016296cc30d6cdfccf1f324e60ccd07cd06ff"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484152115188620,
"parent_rev": "c197aaf856fea65148a930dd4219937d0749f12d", "commit_rev":
"9ac016296cc30d6cdfccf1f324e60ccd07cd06ff"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484152115188620,
"parent_rev": "c197aaf856fea65148a930dd4219937d0749f12d", "commit_rev":
"9ac016296cc30d6cdfccf1f324e60ccd07cd06ff"}
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by kylechar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484158085789720,
"parent_rev": "273a38965bc5b14d88d54ae1b5eb455d0343f2b6", "commit_rev":
"3ae6c6b59c0c9a5609fb220d7c494649ad1e826a"}
Message was sent while issue was closed.
Description was changed from ========== Create TaskScheduler for all Mojo apps. Running mustash on device currently crashes on startup. This is because ui::Service doesn't create a TaskScheduler before Ozone DRM uses it. One option is to have ui::Service::OnStart() create a TaskScheduler. If other Mojo applications need a task scheduler they'll have to do the same. Instead, have MashRunner start a TaskRunner for each process. This fixes the crash in Ozone DRM and doesn't seem to cause any other problems. BUG=679840 ========== to ========== Create TaskScheduler for all Mojo apps. Running mustash on device currently crashes on startup. This is because ui::Service doesn't create a TaskScheduler before Ozone DRM uses it. One option is to have ui::Service::OnStart() create a TaskScheduler. If other Mojo applications need a task scheduler they'll have to do the same. Instead, have MashRunner start a TaskRunner for each process. This fixes the crash in Ozone DRM and doesn't seem to cause any other problems. BUG=679840 Review-Url: https://codereview.chromium.org/2621153003 Cr-Commit-Position: refs/heads/master@{#442956} Committed: https://chromium.googlesource.com/chromium/src/+/3ae6c6b59c0c9a5609fb220d7c49... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3ae6c6b59c0c9a5609fb220d7c49... |
