Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2621143003: Replace manual y coordinate flipping with gfx::ScreenRectFromNSRect(). (Closed)

Created:
3 years, 11 months ago by themblsha
Modified:
3 years, 11 months ago
Reviewers:
Avi (use Gerrit), boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace manual y coordinate flipping with gfx::ScreenRectFromNSRect(). BUG=None Review-Url: https://codereview.chromium.org/2621143003 Cr-Commit-Position: refs/heads/master@{#443181} Committed: https://chromium.googlesource.com/chromium/src/+/4d99af5bd30d9239c34e70c55862891529fc0f91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/browser/web_contents/web_contents_view_mac.mm View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
themblsha
I thought that the benefits of the change were self evident (less code to maintain, ...
3 years, 11 months ago (2017-01-11 14:46:28 UTC) #2
boliu
I'm only supposed to do reviews for android, and can't really read objective c -> ...
3 years, 11 months ago (2017-01-11 17:14:28 UTC) #4
Avi (use Gerrit)
lgtm
3 years, 11 months ago (2017-01-11 17:19:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621143003/1
3 years, 11 months ago (2017-01-12 07:11:58 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 08:03:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d99af5bd30d9239c34e70c55862...

Powered by Google App Engine
This is Rietveld 408576698