Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2621103002: Remove GCMMessageCryptographer::Label (Closed)

Created:
3 years, 11 months ago by Peter Beverloo
Modified:
3 years, 11 months ago
Reviewers:
johnme
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GCMMessageCryptographer::Label It's only got one value, and there are no plans to add more. BUG=679789 Review-Url: https://codereview.chromium.org/2621103002 Cr-Commit-Position: refs/heads/master@{#442650} Committed: https://chromium.googlesource.com/chromium/src/+/ee0b6869f2fa3f22f107058ed8f2ba868e5f01ff

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove GCMMessageCryptographer::Label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M components/gcm_driver/crypto/gcm_crypto_test_helpers.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/gcm_driver/crypto/gcm_message_cryptographer.h View 1 1 chunk +3 lines, -9 lines 0 comments Download
M components/gcm_driver/crypto/gcm_message_cryptographer.cc View 4 chunks +5 lines, -13 lines 0 comments Download
M components/gcm_driver/crypto/gcm_message_cryptographer_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
johnme
lgtm with nit https://codereview.chromium.org/2621103002/diff/1/components/gcm_driver/crypto/gcm_message_cryptographer.h File components/gcm_driver/crypto/gcm_message_cryptographer.h (right): https://codereview.chromium.org/2621103002/diff/1/components/gcm_driver/crypto/gcm_message_cryptographer.h#newcode40 components/gcm_driver/crypto/gcm_message_cryptographer.h:40: // Creates a new cryptographer, identifying ...
3 years, 11 months ago (2017-01-10 18:10:52 UTC) #3
Peter Beverloo
https://codereview.chromium.org/2621103002/diff/1/components/gcm_driver/crypto/gcm_message_cryptographer.h File components/gcm_driver/crypto/gcm_message_cryptographer.h (right): https://codereview.chromium.org/2621103002/diff/1/components/gcm_driver/crypto/gcm_message_cryptographer.h#newcode40 components/gcm_driver/crypto/gcm_message_cryptographer.h:40: // Creates a new cryptographer, identifying the group used ...
3 years, 11 months ago (2017-01-10 18:11:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621103002/20001
3 years, 11 months ago (2017-01-10 18:12:27 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:16:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ee0b6869f2fa3f22f107058ed8f2...

Powered by Google App Engine
This is Rietveld 408576698